Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751824AbbFRC5V (ORCPT ); Wed, 17 Jun 2015 22:57:21 -0400 Received: from mail.windriver.com ([147.11.1.11]:35638 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbbFRC5M (ORCPT ); Wed, 17 Jun 2015 22:57:12 -0400 Message-ID: <5582336D.9020402@windriver.com> Date: Thu, 18 Jun 2015 10:56:45 +0800 From: Ying Xue User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nicholas Krause , CC: , , , Subject: Re: [PATCH] tipc:Make the function tipc_buf_append have a return type of bool References: <1434595459-24040-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1434595459-24040-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [147.11.103.221] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2847 Lines: 79 On 06/18/2015 10:44 AM, Nicholas Krause wrote: > This converts the function tipc_buf_append now due to this > particular function only returning either one or zero as > its return value. > > Signed-off-by: Nicholas Krause Acked-by: Ying Xue > --- > net/tipc/msg.c | 12 ++++++------ > net/tipc/msg.h | 2 +- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/net/tipc/msg.c b/net/tipc/msg.c > index c3e96e8..52f2978 100644 > --- a/net/tipc/msg.c > +++ b/net/tipc/msg.c > @@ -115,9 +115,9 @@ struct sk_buff *tipc_msg_create(uint user, uint type, > * out: set when successful non-complete reassembly, otherwise NULL > * @*buf: in: the buffer to append. Always defined > * out: head buf after successful complete reassembly, otherwise NULL > - * Returns 1 when reassembly complete, otherwise 0 > + * Returns true when reassembly complete, otherwise false > */ > -int tipc_buf_append(struct sk_buff **headbuf, struct sk_buff **buf) > +bool tipc_buf_append(struct sk_buff **headbuf, struct sk_buff **buf) > { > struct sk_buff *head = *headbuf; > struct sk_buff *frag = *buf; > @@ -144,7 +144,7 @@ int tipc_buf_append(struct sk_buff **headbuf, struct sk_buff **buf) > skb_frag_list_init(head); > TIPC_SKB_CB(head)->tail = NULL; > *buf = NULL; > - return 0; > + return false; > } > > if (!head) > @@ -171,16 +171,16 @@ int tipc_buf_append(struct sk_buff **headbuf, struct sk_buff **buf) > *buf = head; > TIPC_SKB_CB(head)->tail = NULL; > *headbuf = NULL; > - return 1; > + return true; > } > *buf = NULL; > - return 0; > + return false; > err: > pr_warn_ratelimited("Unable to build fragment list\n"); > kfree_skb(*buf); > kfree_skb(*headbuf); > *buf = *headbuf = NULL; > - return 0; > + return false; > } > > /* tipc_msg_validate - validate basic format of received message > diff --git a/net/tipc/msg.h b/net/tipc/msg.h > index e1d3595e..00d3357 100644 > --- a/net/tipc/msg.h > +++ b/net/tipc/msg.h > @@ -771,7 +771,7 @@ void tipc_msg_init(u32 own_addr, struct tipc_msg *m, u32 user, u32 type, > struct sk_buff *tipc_msg_create(uint user, uint type, uint hdr_sz, > uint data_sz, u32 dnode, u32 onode, > u32 dport, u32 oport, int errcode); > -int tipc_buf_append(struct sk_buff **headbuf, struct sk_buff **buf); > +bool tipc_buf_append(struct sk_buff **headbuf, struct sk_buff **buf); > bool tipc_msg_bundle(struct sk_buff *bskb, struct sk_buff *skb, u32 mtu); > > bool tipc_msg_make_bundle(struct sk_buff **skb, u32 mtu, u32 dnode); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/