Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbbFRDSf (ORCPT ); Wed, 17 Jun 2015 23:18:35 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:32927 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbbFRDS2 (ORCPT ); Wed, 17 Jun 2015 23:18:28 -0400 Message-ID: <55823878.7050108@huawei.com> Date: Thu, 18 Jun 2015 11:18:16 +0800 From: Zefan Li User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Adrian Knoth CC: , , , Takashi Iwai Subject: Re: [PATCH 3.4 035/172] ALSA: hdspm - Constrain periods to 2 on older cards References: <1434443587-4599-1-git-send-email-lizf@kernel.org> <1434443826-4929-35-git-send-email-lizf@kernel.org> <557FF02B.1080209@drcomp.erfurt.thur.de> In-Reply-To: <557FF02B.1080209@drcomp.erfurt.thur.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.18.230] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 913 Lines: 26 >> @@ -6042,6 +6042,12 @@ static int snd_hdspm_capture_open(struct snd_pcm_substream *substream) >> snd_pcm_hw_constraint_minmax(runtime, >> SNDRV_PCM_HW_PARAM_PERIOD_SIZE, >> 64, 8192); >> + snd_pcm_hw_constraint_minmax(runtime, >> + SNDRV_PCM_HW_PARAM_PERIODS, >> + 2, 2); >> + snd_pcm_hw_constraint_minmax(runtime, >> + SNDRV_PCM_HW_PARAM_PERIODS, >> + 2, 2); >> break; >> } > > This is not correct, those lines need to go to two different functions > (snd_hdspm_playback_open and snd_hdspm_capture_open). > > Here is how the patch should look like: > Now fixed. Thanks for review the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/