Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbbFRFwn (ORCPT ); Thu, 18 Jun 2015 01:52:43 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55037 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbbFRFwg (ORCPT ); Thu, 18 Jun 2015 01:52:36 -0400 Message-ID: <55825C9F.4060104@suse.de> Date: Thu, 18 Jun 2015 07:52:31 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Maninder Singh , JBottomley@odin.com, hch@lst.de, michaelc@cs.wisc.edu, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org CC: pankaj.m@samsung.com Subject: Re: [PATCH 1/1] scsi: use kzalloc for allocating one thing References: <1434602194-14484-1-git-send-email-maninder1.s@samsung.com> In-Reply-To: <1434602194-14484-1-git-send-email-maninder1.s@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 39 On 06/18/2015 06:36 AM, Maninder Singh wrote: > Use kzalloc rather than kcalloc(1,...) for allocating one thing > > Signed-off-by: Maninder Singh > Reviewed-by: Vaneet Narang > --- > drivers/scsi/mvsas/mv_init.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c > index d40d734..65e47eb 100644 > --- a/drivers/scsi/mvsas/mv_init.c > +++ b/drivers/scsi/mvsas/mv_init.c > @@ -558,7 +558,7 @@ static int mvs_pci_init(struct pci_dev *pdev, const struct pci_device_id *ent) > > chip = &mvs_chips[ent->driver_data]; > SHOST_TO_SAS_HA(shost) = > - kcalloc(1, sizeof(struct sas_ha_struct), GFP_KERNEL); > + kzalloc(sizeof(struct sas_ha_struct), GFP_KERNEL); > if (!SHOST_TO_SAS_HA(shost)) { > kfree(shost); > rc = -ENOMEM; > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/