Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753221AbbFRHMr (ORCPT ); Thu, 18 Jun 2015 03:12:47 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:34604 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752870AbbFRHMk (ORCPT ); Thu, 18 Jun 2015 03:12:40 -0400 Message-ID: <1434611556.2385.8.camel@x220> Subject: Re: [PATCH] clk: at91: add generated clock driver From: Paul Bolle To: Nicolas Ferre Cc: Boris BREZILLON , linux-arm-kernel@lists.infradead.org, Alexandre Belloni , Ludovic Desroches , Josh Wu , linux-kernel@vger.kernel.org, mturquette@baylibre.com Date: Thu, 18 Jun 2015 09:12:36 +0200 In-Reply-To: <1434547409-12232-1-git-send-email-nicolas.ferre@atmel.com> References: <1434547409-12232-1-git-send-email-nicolas.ferre@atmel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 903 Lines: 41 On Wed, 2015-06-17 at 15:23 +0200, Nicolas Ferre wrote: > --- a/arch/arm/mach-at91/Kconfig > +++ b/arch/arm/mach-at91/Kconfig > +config HAVE_AT91_GENERATED > + bool This will always be 'n'. > --- a/drivers/clk/at91/Makefile > +++ b/drivers/clk/at91/Makefile > +obj-$(CONFIG_HAVE_AT91_GENERATED) += clk-generated.o And clk-generated.o will never be built. I think your options are to use config HAVE_AT91_GENERATED def_bool y or config HAVE_AT91_GENERATED bool "Yadda yadda yadda" or add select HAVE_AT91_GENERATED somewhere (possibly even in a second patch). But as it stands the patch looks like an elaborate NOP. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/