Date: Thu, 18 Jun 2015 15:29:41 +0800
From: Dong Aisheng <b29396@freescale.com>
To: Suneel Garapati <suneel.garapati@xilinx.com>
CC: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>, <michals@xilinx.com>,
        <sorenb@xilinx.com>, "Adrian Hunter" <adrian.hunter@intel.com>,
        Haibo Chen <haibo.chen@freescale.com>,
        Tim Kryger <tim.kryger@gmail.com>, Shawn Guo <shawn.guo@linaro.org>,
        Yi Sun <yi.y.sun@intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, <stripathi@apm.com>
Subject: Re: [PATCH] drivers: mmc: sdhci: update max frequency only if
 undefined
Message-ID: <20150618072939.GA31104@shlinux1.ap.freescale.net>
References: <1434612427-1758-1-git-send-email-suneel.garapati@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1434612427-1758-1-git-send-email-suneel.garapati@xilinx.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2015 07:33:30.8395
 (UTC)
X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1386
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1476
Lines: 45

On Thu, Jun 18, 2015 at 12:57:07PM +0530, Suneel Garapati wrote:
> f_max parameter of mmc structure is updated unconditionally.
> If dt property max-frequency is assigned, this update is
> overwriting the dt property value which is undesired.
> 
> Signed-off-by: Suneel Garapati <suneel.garapati@xilinx.com>
> ---
>  drivers/mmc/host/sdhci.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index bc14452..c2917d5 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3047,7 +3047,10 @@ int sdhci_add_host(struct sdhci_host *host)
> 	 * Set host parameters.
> 	 */
> 	mmc->ops = &sdhci_ops;
> -	mmc->f_max = host->max_clk;
> +
> +	if(!mmc->f_max)
> +		mmc->f_max = host->max_clk;
> +

This is probably not going to work properly.
mmc->f_max will be overwritten again if host->clk_mul enabled.
And you did not do sanity check if f_max from device tree is valid.

Please see:
http://www.spinics.net/lists/arm-kernel/msg426167.html
I already sent a proper fix.

Regards
Dong Aisheng

> 	if (host->ops->get_min_clock)
> 		mmc->f_min = host->ops->get_min_clock(host);
> 	else if (host->version >= SDHCI_SPEC_300) {
> --
> 2.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/