Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbbFRHeH (ORCPT ); Thu, 18 Jun 2015 03:34:07 -0400 Received: from down.free-electrons.com ([37.187.137.238]:53784 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753379AbbFRHds (ORCPT ); Thu, 18 Jun 2015 03:33:48 -0400 Date: Thu, 18 Jun 2015 09:33:44 +0200 From: Boris Brezillon To: Paul Bolle Cc: Nicolas Ferre , linux-arm-kernel@lists.infradead.org, Alexandre Belloni , Ludovic Desroches , Josh Wu , linux-kernel@vger.kernel.org, mturquette@baylibre.com Subject: Re: [PATCH] clk: at91: add generated clock driver Message-ID: <20150618093344.7d486e97@bbrezillon> In-Reply-To: <1434611556.2385.8.camel@x220> References: <1434547409-12232-1-git-send-email-nicolas.ferre@atmel.com> <1434611556.2385.8.camel@x220> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 51 Hi Paul, On Thu, 18 Jun 2015 09:12:36 +0200 Paul Bolle wrote: > On Wed, 2015-06-17 at 15:23 +0200, Nicolas Ferre wrote: > > > --- a/arch/arm/mach-at91/Kconfig > > +++ b/arch/arm/mach-at91/Kconfig > > > +config HAVE_AT91_GENERATED > > + bool > > This will always be 'n'. > > > --- a/drivers/clk/at91/Makefile > > +++ b/drivers/clk/at91/Makefile > > > +obj-$(CONFIG_HAVE_AT91_GENERATED) += clk-generated.o > > And clk-generated.o will never be built. > > I think your options are to use > config HAVE_AT91_GENERATED > def_bool y > > or > config HAVE_AT91_GENERATED > bool "Yadda yadda yadda" > > or add > select HAVE_AT91_GENERATED > > somewhere (possibly even in a second patch). But as it stands the patch > looks like an elaborate NOP. I guess it will be selected by platforms embedding such clks. We just have to wait for those platform to reach mainline ;-). Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/