Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450AbbFRHmD (ORCPT ); Thu, 18 Jun 2015 03:42:03 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:48712 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752746AbbFRHlz (ORCPT ); Thu, 18 Jun 2015 03:41:55 -0400 Message-ID: <55827606.7020908@atmel.com> Date: Thu, 18 Jun 2015 09:40:54 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paul Bolle CC: Boris Brezillon , , Alexandre Belloni , Ludovic Desroches , Josh Wu , , Subject: Re: [PATCH] clk: at91: add generated clock driver References: <1434547409-12232-1-git-send-email-nicolas.ferre@atmel.com> <1434611556.2385.8.camel@x220> <20150618093344.7d486e97@bbrezillon> In-Reply-To: <20150618093344.7d486e97@bbrezillon> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1625 Lines: 58 Le 18/06/2015 09:33, Boris Brezillon a ?crit : > Hi Paul, > > On Thu, 18 Jun 2015 09:12:36 +0200 > Paul Bolle wrote: > >> On Wed, 2015-06-17 at 15:23 +0200, Nicolas Ferre wrote: >> >>> --- a/arch/arm/mach-at91/Kconfig >>> +++ b/arch/arm/mach-at91/Kconfig >> >>> +config HAVE_AT91_GENERATED >>> + bool >> >> This will always be 'n'. >> >>> --- a/drivers/clk/at91/Makefile >>> +++ b/drivers/clk/at91/Makefile >> >>> +obj-$(CONFIG_HAVE_AT91_GENERATED) += clk-generated.o >> >> And clk-generated.o will never be built. >> >> I think your options are to use >> config HAVE_AT91_GENERATED >> def_bool y >> >> or >> config HAVE_AT91_GENERATED >> bool "Yadda yadda yadda" >> >> or add >> select HAVE_AT91_GENERATED >> >> somewhere (possibly even in a second patch). But as it stands the patch >> looks like an elaborate NOP. > > I guess it will be selected by platforms embedding such clks. We just > have to wait for those platform to reach mainline ;-). Yes, absolutely. I am in the process, with my colleagues, of building bricks for our upcoming SoC the sama5d2. So, the basic support for this chip will come in the next weeks and will select this Kconfig option. I'd like though that this matter of fact doesn't block this piece of code from being reviewed or even better merged in order to ease this new SoC landing... Bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/