Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753952AbbFRJB5 (ORCPT ); Thu, 18 Jun 2015 05:01:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51321 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752368AbbFRJBq (ORCPT ); Thu, 18 Jun 2015 05:01:46 -0400 Date: Thu, 18 Jun 2015 11:01:44 +0200 (CEST) From: Jiri Kosina To: Fabian Frederick cc: linux-kernel@vger.kernel.org, Julia Lawall , linux-input@vger.kernel.org Subject: Re: [PATCH 1/1 linux-next] HID: use swap() in cp_report_fixup() In-Reply-To: <1433953925-23857-1-git-send-email-fabf@skynet.be> Message-ID: References: <1433953925-23857-1-git-send-email-fabf@skynet.be> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 42 On Wed, 10 Jun 2015, Fabian Frederick wrote: > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick Applied to for-4.2/upstream. Thanks. > --- > drivers/hid/hid-cypress.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/hid/hid-cypress.c b/drivers/hid/hid-cypress.c > index c4ef3bc..1b764d1 100644 > --- a/drivers/hid/hid-cypress.c > +++ b/drivers/hid/hid-cypress.c > @@ -41,13 +41,9 @@ static __u8 *cp_report_fixup(struct hid_device *hdev, __u8 *rdesc, > > for (i = 0; i < *rsize - 4; i++) > if (rdesc[i] == 0x29 && rdesc[i + 2] == 0x19) { > - __u8 tmp; > - > rdesc[i] = 0x19; > rdesc[i + 2] = 0x29; > - tmp = rdesc[i + 3]; > - rdesc[i + 3] = rdesc[i + 1]; > - rdesc[i + 1] = tmp; > + swap(rdesc[i + 3], rdesc[i + 1]); > } > return rdesc; > } -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/