Message-ID: <1434619943.2385.59.camel@x220>
Subject: Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg
From: Paul Bolle <pebolle@tiscali.nl>
To: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: York Sun <yorksun@freescale.com>, wsa@the-dreams.de,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        Peter Korsgaard <peter.korsgaard@barco.com>
Date: Thu, 18 Jun 2015 11:32:23 +0200
In-Reply-To: <5582899B.9030307@nokia.com>
References: <1434475692-4611-1-git-send-email-yorksun@freescale.com>
	 <1434531244.2069.111.camel@x220> <55818BAB.5090605@nokia.com>
	 <1434556990.2400.16.camel@x220> <558275F1.5020100@nokia.com>
	 <1434614901.2385.27.camel@x220> <5582899B.9030307@nokia.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1307
Lines: 33

On Thu, 2015-06-18 at 11:04 +0200, Alexander Sverdlin wrote:
> Maybe (and hopefully) there will never be a legacy user of this driver. But this macro
> is perfectly fine, adds no overhead (but modinfo)

(The test for any line of code is whether it adds value. Adding no
overhead is not adding value. That goes for one line macros too.)

>  and make the module "complete" in a
> sense that it supports both types of binding. There is a legacy probe function in it,
> all the support for legacy binding with platform_data in it and this modalias is simply
> the last part of it.

As I understand it, we've established that:
- this macro setups up udev, and modprobe, and friends, to listen to a
"MODALIAS=platform:i2c-mux-reg" message; and
- that there's currently no code in the kernel that will send out this
message.

Did I get that right? Because it follows from the above that this line
serves no purpose. Worse, it makes the code actually confusing. Because
it suggests the availability of functionality that in reality doesn't
exist.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/