Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755242AbbFROTc (ORCPT ); Thu, 18 Jun 2015 10:19:32 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34477 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbbFROT0 (ORCPT ); Thu, 18 Jun 2015 10:19:26 -0400 MIME-Version: 1.0 In-Reply-To: <1829815.c8lIHLtv9K@avalon> References: <1434622954-26747-1-git-send-email-geert+renesas@glider.be> <1434622954-26747-2-git-send-email-geert+renesas@glider.be> <1829815.c8lIHLtv9K@avalon> Date: Thu, 18 Jun 2015 16:19:25 +0200 X-Google-Sender-Auth: MW-2JGSSBehvUJe-keUVsHHT0_Q Message-ID: Subject: Re: [PATCH 1/2] clocksource: sh_cmt: Only perform clocksource suspend/resume if enabled From: Geert Uytterhoeven To: Laurent Pinchart Cc: Geert Uytterhoeven , Linux PM list , Daniel Lezcano , Thomas Gleixner , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Magnus Damm , Linux-sh list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 41 Hi Laurent, On Thu, Jun 18, 2015 at 4:14 PM, Laurent Pinchart wrote: > On Thursday 18 June 2015 12:22:33 Geert Uytterhoeven wrote: >> Currently the sh_cmt clocksource timer is disabled or enabled >> unconditionally on clocksource suspend resp. resume, even if a better >> clocksource is present (e.g. arch_sys_counter) and the sh_cmt >> clocksource is not enabled. >> Signed-off-by: Geert Uytterhoeven > > Good catch. The patch looks good to me. While the solution was simple, it was hard to catch (engineers and lightbulbs... euh timers ;-) > Acked-by: Laurent Pinchart Thanks! > I've quickly checked the MTU2 and TMU timer drivers and they should be immune > to the issue, but I'd appreciate if you could confirm that. I had concluded the same, thanks for verifying! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/