Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896AbbFROmw (ORCPT ); Thu, 18 Jun 2015 10:42:52 -0400 Received: from foss.arm.com ([217.140.101.70]:42651 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751850AbbFROmo (ORCPT ); Thu, 18 Jun 2015 10:42:44 -0400 Date: Thu, 18 Jun 2015 15:42:39 +0100 From: Catalin Marinas To: Maninder Singh Cc: will.deacon@arm.com, sungjinn.chung@samsung.com, jays.lee@samsung.com, kgene.kim@samsung.com, behanw@converseincode.com, punit.agrawal@arm.com, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rohit Thapliyal , pankaj.m@samsung.com Subject: Re: [RFC][PATCH] arm64:Modify the dump mem for 64 bit addresses Message-ID: <20150618144239.GD31480@e104818-lin.cambridge.arm.com> References: <1434605226-17084-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434605226-17084-1-git-send-email-maninder1.s@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1617 Lines: 41 On Thu, Jun 18, 2015 at 10:57:06AM +0530, Maninder Singh wrote: > From: Rohit Thapliyal > > On 64bit kernel, the dump_mem gives 32 bit addresses > on the stack dump. This gives unorganized information regarding > the 64bit values on the stack. Hence, modified to get a complete > 64bit memory dump. [...] > The above output makes a debugger life a lot more easier. > > Signed-off-by: Rohit Thapliyal > Signed-off-by: Maninder Singh > Reviewed-by: Akhilesh Kumar > --- > arch/arm64/kernel/traps.c | 62 +++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 60 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > index 1ef2940..6e9f19b 100644 > --- a/arch/arm64/kernel/traps.c > +++ b/arch/arm64/kernel/traps.c > @@ -51,6 +51,48 @@ int show_unhandled_signals = 1; > /* > * Dump out the contents of some memory nicely... > */ > + > +static void dump_mem64(const char *lvl, const char *str, unsigned long bottom, > + unsigned long top) While I'm not against the idea, can you not add a "width" or "wide" argument to the dump_mem() function and share the code? This function is very similar to the original dump_mem() implementation and it would be nice to avoid some code duplication. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/