Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755893AbbFRPps (ORCPT ); Thu, 18 Jun 2015 11:45:48 -0400 Received: from down.free-electrons.com ([37.187.137.238]:43298 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754392AbbFRPpj (ORCPT ); Thu, 18 Jun 2015 11:45:39 -0400 Date: Thu, 18 Jun 2015 17:45:37 +0200 From: Alexandre Belloni To: Josh Wu Cc: Nicolas Ferre , linux-arm-kernel@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Rob Herring , Kumar Gala , Jean-Christophe Plagniol-Villard , Andrew Victor Subject: Re: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board Message-ID: <20150618154537.GM27492@piout.net> References: <1434449315-9243-1-git-send-email-josh.wu@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434449315-9243-1-git-send-email-josh.wu@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 24 Hi, Seems good to me, a small comment below: On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote : > @@ -1068,8 +1076,12 @@ > clocks = <&isi_clk>; > clock-names = "isi_clk"; > pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_isi>; > + pinctrl-0 = <&pinctrl_isi_data_0_7>; I would say that the pinctrl is board specific so both pinctrl-names and pinctrl-0 should go to at91sam9m10g45ek.dts -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/