Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756090AbbFRQmd (ORCPT ); Thu, 18 Jun 2015 12:42:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55712 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbbFRQmY (ORCPT ); Thu, 18 Jun 2015 12:42:24 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <5582F307.6030005@tycho.nsa.gov> References: <5582F307.6030005@tycho.nsa.gov> <22037.1434644340@warthog.procyon.org.uk> To: Stephen Smalley Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, SELinux , Paul Moore Subject: Re: [PATCH] SELinux: Create a common helper to determine an inode label MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1604.1434645740.1@warthog.procyon.org.uk> Date: Thu, 18 Jun 2015 17:42:20 +0100 Message-ID: <1605.1434645740@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 591 Lines: 15 Stephen Smalley wrote: > > + rc = selinux_determine_inode_label(d_inode(dentry), name, > > Hmmm...previously we were using d_backing_inode(dentry->d_parent) here. I also think this should probably be d_inode() not d_backing_inode() since we're being called by the filesystem that owns the dentry being contemplated. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/