Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756046AbbFRRZV (ORCPT ); Thu, 18 Jun 2015 13:25:21 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:44417 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbbFRRZO (ORCPT ); Thu, 18 Jun 2015 13:25:14 -0400 Message-ID: <5582FEF4.3090708@ti.com> Date: Thu, 18 Jun 2015 12:25:08 -0500 From: Suman Anna User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Rob Herring CC: Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ohad Ben-Cohen Subject: Re: [PATCH] of: define of_find_node_by_phandle for !CONFIG_OF References: <1434560033-26681-1-git-send-email-s-anna@ti.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1490 Lines: 50 On 06/17/2015 06:33 PM, Rob Herring wrote: > On Wed, Jun 17, 2015 at 11:53 AM, Suman Anna wrote: >> Define stub implementation for of_find_node_by_phandle() API >> so that users of this API can build properly even when CONFIG_OF >> is not defined. >> >> Signed-off-by: Suman Anna > > Do you have a user for this? If not, apply it when you do. Yeah, ran into a randconfig build problem on x86 when we tried to add an API to remoteproc core [1] that used this function. regards Suman [1] http://marc.info/?l=devicetree&m=143232772426559&w=2 > > Acked-by: Rob Herring > >> --- >> include/linux/of.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/linux/of.h b/include/linux/of.h >> index ddeaae6d2083..90dfdc47ae26 100644 >> --- a/include/linux/of.h >> +++ b/include/linux/of.h >> @@ -422,6 +422,11 @@ static inline struct device_node *of_find_node_opts_by_path(const char *path, >> return NULL; >> } >> >> +static inline struct device_node *of_find_node_by_phandle(phandle handle) >> +{ >> + return NULL; >> +} >> + >> static inline struct device_node *of_get_parent(const struct device_node *node) >> { >> return NULL; >> -- >> 2.4.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/