Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756290AbbFRRZo (ORCPT <rfc822;w@1wt.eu>);
	Thu, 18 Jun 2015 13:25:44 -0400
Received: from smtprelay0012.hostedemail.com ([216.40.44.12]:45180 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1754667AbbFRRZh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 18 Jun 2015 13:25:37 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3873:3874:4321:4362:4605:5007:6119:6261:7875:7903:7904:8660:8784:9040:9163:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12114:12438:12517:12519:12555:12740:13148:13230:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: crook99_30b7311cf5252
X-Filterd-Recvd-Size: 3342
Date: Thu, 18 Jun 2015 13:25:33 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: perf/ftrace: fuzzer triggers another warning with
 PERF_EVENT_IOC_SET_FILTER
Message-ID: <20150618132533.47ddf3eb@gandalf.local.home>
In-Reply-To: <alpine.DEB.2.20.1506171926201.19626@vincent-weaver-1.umelst.maine.edu>
References: <alpine.DEB.2.20.1506171926201.19626@vincent-weaver-1.umelst.maine.edu>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2548
Lines: 56

On Wed, 17 Jun 2015 19:32:26 -0400 (EDT)
Vince Weaver <vincent.weaver@maine.edu> wrote:

> 
> The fuzzer triggered another warning in the PERF_EVENT_IOC_SET_FILTER 
> code.  This is with the previous filter patch applied.
> 
> >From what I can tell the filter was:
> nfs4:nfs4_fsinfo 
> (((fhandle~601)&&valid&809)&&common_type>=860) 

Hmm, I can't trigger this with the filter file, can you?

 echo '(((fhandle~601)&&valid&809)&&common_type>=860)' > \
  /sys/kernel/debug/tracing/events/nfs4/nfs4_fsinfo/filter

I'll write a user app to use the perf syscall and see if that is
different, but in the mean time, can you try the above.

Thanks!

-- Steve

> 
> The warning in question:
> 	WARN_ON_ONCE(cnt < 0);
> in check_preds().
> 
> [65903.660154] WARNING: CPU: 1 PID: 731 at kernel/trace/trace_events_filter.c:1388 replace_preds+0x2e4/0xa50()
> [65903.748080] CPU: 1 PID: 731 Comm: perf_fuzzer Tainted: G        W       4.1.0-rc8+ #157
> [65903.757203] Hardware name: LENOVO 10AM000AUS/SHARKBAY, BIOS FBKT72AUS 01/26/2014
> [65903.765711]  ffffffff81a1ac00 ffff880117117cb8 ffffffff816d7419 0000000000000000
> [65903.774323]  0000000000000000 ffff880117117cf8 ffffffff81072eba 0000000000000005
> [65903.782924]  0000000000000003 ffff8800366bd018 ffff8800366bd000 ffff8800cf3e9220
> [65903.791516] Call Trace:
> [65903.794688]  [<ffffffff816d7419>] dump_stack+0x45/0x57
> [65903.800732]  [<ffffffff81072eba>] warn_slowpath_common+0x8a/0xc0
> [65903.807712]  [<ffffffff81072faa>] warn_slowpath_null+0x1a/0x20
> [65903.814477]  [<ffffffff8114b1c4>] replace_preds+0x2e4/0xa50
> [65903.820974]  [<ffffffff8114c2c3>] ? ftrace_profile_set_filter+0x23/0x100
> [65903.828640]  [<ffffffff8114b9b2>] create_filter+0x82/0xb0
> [65903.834917]  [<ffffffff8114c2f4>] ftrace_profile_set_filter+0x54/0x100
> [65903.842436]  [<ffffffff811909eb>] ? strndup_user+0x4b/0xc0
> [65903.848794]  [<ffffffff81166290>] perf_ioctl+0x170/0x4d0
> [65903.854959]  [<ffffffff812023d0>] do_vfs_ioctl+0x2e0/0x4e0
> [65903.861286]  [<ffffffff816dcdfe>] ? mutex_unlock+0xe/0x10
> [65903.867492]  [<ffffffff81164756>] ? perf_event_task_enable+0xb6/0xd0
> [65903.874754]  [<ffffffff81202651>] SyS_ioctl+0x81/0xa0
> [65903.880655]  [<ffffffff816df372>] system_call_fastpath+0x16/0x7a
> [65903.887534] ---[ end trace 48137d0593a025d9 ]---

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/