Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932317AbbFRRty (ORCPT ); Thu, 18 Jun 2015 13:49:54 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:35258 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282AbbFRRte (ORCPT ); Thu, 18 Jun 2015 13:49:34 -0400 Date: Thu, 18 Jun 2015 13:49:30 -0400 From: Tejun Heo To: Michal Hocko Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, jack@suse.cz, hch@infradead.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org, linux-mm@kvack.org, clm@fb.com, fengguang.wu@intel.com, david@fromorbit.com, gthelen@google.com, khlebnikov@yandex-team.ru Subject: Re: [PATCH 06/51] memcg: add mem_cgroup_root_css Message-ID: <20150618174930.GA12934@mtj.duckdns.org> References: <1432329245-5844-1-git-send-email-tj@kernel.org> <1432329245-5844-7-git-send-email-tj@kernel.org> <20150617145642.GI25056@dhcp22.suse.cz> <20150617182500.GI22637@mtj.duckdns.org> <20150618111227.GA5858@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150618111227.GA5858@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 27 Hello, Michal. On Thu, Jun 18, 2015 at 01:12:27PM +0200, Michal Hocko wrote: ... > I see and yes, it makes some sense. I just think we can get rid of the > accessor functions when the struct mem_cgroup is visible and the code > can simply do &{page->}mem_cgroup->css. As long as the accessors are inline, I think it should be fine. > I have tried to compile with !CONFIG_MEMCG and !CONFIG_CGROUP_WRITEBACK > without mem_cgroup_root_css defined for this configuration and > mm/backing-dev.c compiles just fine. So maybe we should get rid of it > rather than have a potentially tricky code? Yeah, please feel free to queue a patch to remove it if doesn't break anything. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/