Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756599AbbFRSBe (ORCPT ); Thu, 18 Jun 2015 14:01:34 -0400 Received: from mail-yk0-f177.google.com ([209.85.160.177]:34951 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753148AbbFRSB1 (ORCPT ); Thu, 18 Jun 2015 14:01:27 -0400 MIME-Version: 1.0 In-Reply-To: References: <20150618161207.32739.62577.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20150618161238.32739.42666.stgit@bhelgaas-glaptop2.roam.corp.google.com> From: Bjorn Helgaas Date: Thu, 18 Jun 2015 13:01:06 -0500 Message-ID: Subject: Re: [PATCH 1/4] PCI: pciehp: Clean up debug logging To: Rajat Jain Cc: "linux-pci@vger.kernel.org" , Yinghai Lu , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 32 On Thu, Jun 18, 2015 at 12:27 PM, Rajat Jain wrote: > Hi, > > On Thu, Jun 18, 2015 at 9:12 AM, Bjorn Helgaas wrote: >> The pciehp debug logging is overly verbose and often redundant. Almost all >> of the information printed by dbg_ctrl() is also printed by the normal PCI >> core enumeration code and by pcie_init(). >> >> Remove the redundant debug info. >> >> When claiming a pciehp bridge, we print the slot characteristics, e.g., >> >> Slot #6 AttnBtn- AttnInd- PwrInd- PwrCtrl- MRL- Interlock- NoCompl+ LLActRep+ >> >> Add the Hot-Plug Capable and Hot-Plug Surprise bits to this information, > > If the slot is not hotplug capable. then pciehp wouldn't claim it in > the first place. > > So printing of "hotplug capable" may really not be needed.. Yes, I did think about that, and you're right that it probably isn't needed. But the criteria for claiming a slot and deciding whether acpiphp or pciehp should manage it are not 100% clear yet, so I figured it wouldn't hurt to be a bit more transparent. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/