Date: Thu, 18 Jun 2015 15:02:13 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Landley <rob@landley.net>, Jiri Slaby <jslaby@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Kevin Hilman <khilman@linaro.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Vivek Goyal <vgoyal@redhat.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Riku Voipio <riku.voipio@linaro.org>, Jiri Kosina <jkosina@suse.cz>,
        Paul Bolle <pebolle@tiscali.nl>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Davidlohr Bueso <davidlohr@hp.com>,
        Richard Weinberger <richard@nod.at>, Zhigang Lu <zlu@tilera.com>,
        Vineet Gupta <vgupta@synopsys.com>, Richard Kuo <rkuo@codeaurora.org>,
        Max Filippov <jcmvbkbc@gmail.com>,
        Pranith Kumar <bobby.prani@gmail.com>, linux-sh@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        ysato@users.sourceforge.jp
Subject: Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.
Message-ID: <20150618150213.6fd30752@gandalf.local.home>
In-Reply-To: <20150618175931.GA11748@kroah.com>
References: <1434647946.861556@landley.net>
	<1434647946.861922@landley.net>
	<20150618175931.GA11748@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1005
Lines: 40

On Thu, 18 Jun 2015 10:59:31 -0700
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Thu, Jun 18, 2015 at 10:19:19AM -0700, Rob Landley wrote:
> > Changes to existing files to add 0pf j2 board support.
> > 
> 
> That's the second worse commit message and subject: line I've read
> today.

Only the second worse today? Damn, you must get a lot of crappy change
logs.

> 
> And there's no signed off by line.
> 
> And there was no 1/2 patch sent.
> 
> And, most importantly:
> 
> > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> 
> I don't care about arch/sh/ stuff, why are you sending this to me?

Because even when you don't care, you still give back constructive
feedback ;-)

-- Steve


> 
> You have a bit of work to do here...
> 
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/