Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756322AbbFRT3x (ORCPT ); Thu, 18 Jun 2015 15:29:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49651 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754679AbbFRT3o (ORCPT ); Thu, 18 Jun 2015 15:29:44 -0400 Date: Thu, 18 Jun 2015 21:29:32 +0200 From: Jiri Olsa To: Lukas Wunner Cc: Jiri Olsa , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org Subject: Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified Message-ID: <20150618192931.GA11223@krava.redhat.com> References: <201506181332.t5IDWuUq027242@int-mx13.intmail.prod.int.phx2.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201506181332.t5IDWuUq027242@int-mx13.intmail.prod.int.phx2.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1714 Lines: 48 On Thu, Jun 18, 2015 at 01:00:32PM +0200, Lukas Wunner wrote: > Invoking Makefile.perf with prefix= breaks the build since Makefile.perf > hands that variable down to Makefile.build where it overrides > prefix := $(subst ./,,$(OUTPUT)$(dir)/) > > leading to errors like this: > No rule to make target '/usrabspath.o', needed by '/usrlibperf-in.o' hum, what specific make command is failing? jirka > > Fixes: c819e2cf2eb6f65d3208d195d7a0edef6108d5 > Signed-off-by: Lukas Wunner > --- > tools/build/Makefile.build | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build > index 10df572..98cfc38 100644 > --- a/tools/build/Makefile.build > +++ b/tools/build/Makefile.build > @@ -94,12 +94,12 @@ obj-y := $(patsubst %/, %/$(obj)-in.o, $(obj-y)) > subdir-obj-y := $(filter %/$(obj)-in.o, $(obj-y)) > > # '$(OUTPUT)/dir' prefix to all objects > -prefix := $(subst ./,,$(OUTPUT)$(dir)/) > -obj-y := $(addprefix $(prefix),$(obj-y)) > -subdir-obj-y := $(addprefix $(prefix),$(subdir-obj-y)) > +objprefix := $(subst ./,,$(OUTPUT)$(dir)/) > +obj-y := $(addprefix $(objprefix),$(obj-y)) > +subdir-obj-y := $(addprefix $(objprefix),$(subdir-obj-y)) > > # Final '$(obj)-in.o' object > -in-target := $(prefix)$(obj)-in.o > +in-target := $(objprefix)$(obj)-in.o > > PHONY += $(subdir-y) > > -- > 1.8.5.2 (Apple Git-48) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/