Date: Thu, 18 Jun 2015 21:53:31 +0200
From: Andi Kleen <andi@firstfloor.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>, Andi Kleen <andi@firstfloor.org>,
        dm-devel@redhat.com, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [dm-devel] WARNING: at fs/block_dev.c:5 when removing LV on
 removed device
Message-ID: <20150618195331.GD19417@two.firstfloor.org>
References: <20150618165713.GB19417@two.firstfloor.org>
 <20150618180408.GD2321@redhat.com>
 <20150618180804.GC19417@two.firstfloor.org>
 <20150618181619.GE2321@redhat.com>
 <20150618190815.GA6390@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150618190815.GA6390@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 841
Lines: 26

> In that case if I do umount after device has gone away, I can see above
> WARN(). And it does seem to be coming from.
> 
> WARN_ON_ONCE(write_inode_now(inode, true))
> 
> If we failed to write back inode, then warning about it sounds right?

WARN() is for detecting kernel internal consistency problems, like
potential bugs.  It's not for handling IO errors or really
everything that can happen on a non buggy kernel.


> What's wrong with that? Should it be just a kernel log of level KERN_WARN
> instead?

Yes. Something like that.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/