Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757041AbbFRUJE (ORCPT ); Thu, 18 Jun 2015 16:09:04 -0400 Received: from mail-yk0-f181.google.com ([209.85.160.181]:34798 "EHLO mail-yk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756949AbbFRUIz convert rfc822-to-8bit (ORCPT ); Thu, 18 Jun 2015 16:08:55 -0400 MIME-Version: 1.0 In-Reply-To: <20150618165954.GE7710@google.com> References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-11-git-send-email-robh@kernel.org> <20150618165954.GE7710@google.com> From: Rob Herring Date: Thu, 18 Jun 2015 15:08:34 -0500 X-Google-Sender-Auth: qpQIp3nqyKGDkXXxRhRHpLXBCjo Message-ID: Subject: Re: [PATCH 10/15] PCI: kill off set_irq_flags usage To: Bjorn Helgaas Cc: Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Kishon Vijay Abraham I , Murali Karicheri , Thierry Reding , Stephen Warren , Alexandre Courbot , Jingoo Han , Pratyush Anand , Simon Horman , Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , linux-omap , "linux-pci@vger.kernel.org" , "linux-tegra@vger.kernel.org" , SH-Linux Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2339 Lines: 54 On Thu, Jun 18, 2015 at 11:59 AM, Bjorn Helgaas wrote: > On Tue, Jun 09, 2015 at 01:26:36PM -0500, Rob Herring wrote: >> set_irq_flags is ARM specific with custom flags which have genirq >> equivalents. Convert drivers to use the genirq interfaces directly, so we >> can kill off set_irq_flags. The translation of flags is as follows: >> >> IRQF_VALID -> !IRQ_NOREQUEST >> IRQF_PROBE -> !IRQ_NOPROBE >> IRQF_NOAUTOEN -> IRQ_NOAUTOEN >> >> For IRQs managed by an irqdomain, the irqdomain core code handles clearing >> and setting IRQ_NOREQUEST already, so there is no need to do this in >> .map() functions and we can simply remove the set_irq_flags calls. Some >> users also set IRQ_NOPROBE and this has been maintained although it is not >> clear that is really needed. There appears to be a great deal of blind >> copy and paste of this code. >> >> Signed-off-by: Rob Herring >> Cc: Kishon Vijay Abraham I >> Cc: Bjorn Helgaas >> Cc: Murali Karicheri >> Cc: Thierry Reding >> Cc: Stephen Warren >> Cc: Alexandre Courbot >> Cc: Jingoo Han >> Cc: Pratyush Anand >> Cc: Simon Horman >> Cc: Michal Simek >> Cc: "Sören Brinkmann" >> Cc: linux-omap@vger.kernel.org >> Cc: linux-pci@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-tegra@vger.kernel.org >> Cc: linux-sh@vger.kernel.org > > This is the only part of the series on linux-pci, so I assume this will be > merged by somebody else along with the rest. I copied you on the intro, but all the lists and all the maintainers was too long to cc. Being late in the cycle I didn't really intend for this to be for 4.2, but you can pick up this patch if you want to as it doesn't have any dependencies. If you don't, then I will submit the whole series for 4.3. > Acked-by: Bjorn Helgaas Thanks. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/