Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756592AbbFRU0g (ORCPT ); Thu, 18 Jun 2015 16:26:36 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:34304 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbbFRU03 (ORCPT ); Thu, 18 Jun 2015 16:26:29 -0400 Message-ID: <55832971.4070603@gmail.com> Date: Thu, 18 Jun 2015 14:26:25 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Lukas Wunner , Jiri Olsa CC: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org Subject: Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified References: <201506181332.t5IDWuUq027242@int-mx13.intmail.prod.int.phx2.redhat.com> <20150618192931.GA11223@krava.redhat.com> <20150618195955.GA4755@wunner.de> In-Reply-To: <20150618195955.GA4755@wunner.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1564 Lines: 52 On 6/18/15 1:59 PM, Lukas Wunner wrote: > E.g. the Debian "linux-tools" package makes use of that feature: > > MAKE_PERF := $(MAKE) prefix=/usr V=1 ARCH=$(KERNEL_ARCH_PERF) EXTRA_WARNINGS=-Wno-error > > Source: http://anonscm.debian.org/viewvc/kernel/dists/trunk/linux-tools/debian/build/tools/perf/Makefile?view=markup (line 29) > > > The "prefix" parameter is handed down from Makefile.perf to Makefile.build > because it's invoked with $(MAKE), so the command line parameters are > inherited to Makefile.build: > > $(Q)$(MAKE) $(build)=perf > > Source: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/tools/perf/Makefile.perf#n282 > > > That "prefix" feature is broken in all 4.1 release candidates because a It worked for me last week with OL6. I created a standalone perf rpm with 4.1-rc6; it builds just fine with _prefix (rpm variable) set to /usr: %build # prepare directories rm -rf $RPM_BUILD_ROOT cd perf-%{kversion} %global perf_make \ make -s -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=%{_prefix} %{perf_make} DESTDIR=$RPM_BUILD_ROOT all ### ### install ### %install [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT cd perf-%{kversion} %{perf_make} DESTDIR=$RPM_BUILD_ROOT lib=%{_lib} install man -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/