Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936AbbFRW6p (ORCPT ); Thu, 18 Jun 2015 18:58:45 -0400 Received: from mail-yk0-f182.google.com ([209.85.160.182]:32808 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752593AbbFRW6L (ORCPT ); Thu, 18 Jun 2015 18:58:11 -0400 MIME-Version: 1.0 In-Reply-To: <1434665458-28354-1-git-send-email-dhdang@apm.com> References: <1434665458-28354-1-git-send-email-dhdang@apm.com> From: Bjorn Helgaas Date: Thu, 18 Jun 2015 17:57:50 -0500 Message-ID: Subject: Re: [PATCH 1/1] pci: xgene: Fix compilation warning To: Duc Dang Cc: "linux-pci@vger.kernel.org" , linux-arm , "linux-kernel@vger.kernel.org" , Tanmay Inamdar , patches Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1445 Lines: 36 On Thu, Jun 18, 2015 at 5:10 PM, Duc Dang wrote: > commit 979595bcb8da ("PCI: xgene: Allow config access to Root Port even > when link is down") removes the port->link_up check, which makes 'port' > become unused variable. This patch remove struct xgene_pcie_port *port > declaration to avoid compilation warning. > > Signed-off-by: Duc Dang > Signed-off-by: Tanmay Inamdar I folded this fix into the original patch and updated my branch. Thanks! > --- > drivers/pci/host/pci-xgene.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c > index 3684126..105fd83 100644 > --- a/drivers/pci/host/pci-xgene.c > +++ b/drivers/pci/host/pci-xgene.c > @@ -137,8 +137,6 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset) > static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn, > int offset) > { > - struct xgene_pcie_port *port = bus->sysdata; > - > if ((pci_is_root_bus(bus) && devfn != 0) || > xgene_pcie_hide_rc_bars(bus, offset)) > return NULL; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/