Message-ID: <1434673443.2689.115.camel@perches.com>
Subject: Re: [PATCH] staging: wlan-ng: Fix memset warning found by sparse
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Bilel DRIRA <bilel.dr@gmail.com>, eng.douglasfigueiredo@gmail.com,
        matt@ninezulu.com, josh@joshtriplett.org, raghav3276@gmail.com,
        tapaswenipathak@gmail.com, artemiyv@acm.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Thu, 18 Jun 2015 17:24:03 -0700
In-Reply-To: <20150618230407.GD32238@kroah.com>
References: <1434649791-4730-1-git-send-email-bilel.dr@gmail.com>
	 <20150618230407.GD32238@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1096
Lines: 29

On Thu, 2015-06-18 at 16:04 -0700, Greg KH wrote:
> On Thu, Jun 18, 2015 at 06:49:51PM +0100, Bilel DRIRA wrote:
> > This patch fixes the following sparse warnings:
[]
> > diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
[]
> > @@ -245,10 +245,12 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr,
[]
> > -	memset(s3data, 0, sizeof(s3data));
> > +	for (s3data_count = 0; s3data_count < S3DATA_MAX; s3data_count++)
> > +		memset(&s3data[s3data_count], 0, sizeof(struct s3datarec));
> 
> You are doing the exact same thing here that the original code did, so
> why change it?
> 
> That sparse warning is just a hint, I don't see anything wrong here with
> the original code, sorry.

Greg's right.

A possible improvement would be to malloc/free memory
as necessary instead of using large static buffers.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/