MIME-Version: 1.0
Reply-To: cw00.choi@samsung.com
In-Reply-To: <1434638631-16451-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
References: <1434638631-16451-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
	<1434638631-16451-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
Date: Fri, 19 Jun 2015 11:14:33 +0900
Message-ID: <CAGTfZH0zPbxOTbavXbwKfuetKXdGLctTs+PE_gb8C_6bfkJhbQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/5] extcon: arizona: Update to use the new device
 properties API
From: Chanwoo Choi <cwchoi00@gmail.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Lee Jones <lee.jones@linaro.org>,
        "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
        Samuel Ortiz <sameo@linux.intel.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        patches@opensource.wolfsonmicro.com
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2427
Lines: 63

Hi Charles,

Looks good to me about this patch. But I add one comment.

On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax
<ckeepax@opensource.wolfsonmicro.com> wrote:
> The device properties API will load data from both device tree and ACPI,
> update the binding to use this API instead of the OF API.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 9262b45..1153929 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -24,6 +24,7 @@
>  #include <linux/input.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/property.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/extcon.h>
>
> @@ -1110,12 +1111,12 @@ static void arizona_micd_set_level(struct arizona *arizona, int index,
>         regmap_update_bits(arizona->regmap, reg, mask, level);
>  }
>
> -static int arizona_extcon_of_get_pdata(struct arizona *arizona)
> +static int arizona_extcon_device_get_pdata(struct arizona *arizona)
>  {
>         struct arizona_pdata *pdata = &arizona->pdata;
>         unsigned int val = ARIZONA_ACCDET_MODE_HPL;
>
> -       of_property_read_u32(arizona->dev->of_node, "wlf,hpdet-channel", &val);
> +       device_property_read_u32(arizona->dev, "wlf,hpdet-channel", &val);
>         switch (val) {
>         case ARIZONA_ACCDET_MODE_HPL:
>         case ARIZONA_ACCDET_MODE_HPR:
> @@ -1149,7 +1150,7 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>
>         if (IS_ENABLED(CONFIG_OF)) {

If you remain the upper if statement, I think
"device_property_read_u32" function cannot get the data from ACPI. I
think that you can remove upper if statement of "CONFIG_OF".

>                 if (!dev_get_platdata(arizona->dev))
> -                       arizona_extcon_of_get_pdata(arizona);
> +                       arizona_extcon_device_get_pdata(arizona);
>         }
>
>         info->micvdd = devm_regulator_get(&pdev->dev, "MICVDD");

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/