Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbbFSDPV (ORCPT ); Thu, 18 Jun 2015 23:15:21 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33503 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbbFSDPN (ORCPT ); Thu, 18 Jun 2015 23:15:13 -0400 Date: Fri, 19 Jun 2015 08:45:05 +0530 From: Vaishali Thakkar To: "Ed L. Cashin" Cc: linux-kernel@vger.kernel.org Subject: [PATCH] aoe: Convert use of __constant_ to Message-ID: <20150619031505.GA17748@vaishali-Ideapad-Z570> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2196 Lines: 66 In little endian cases, the macros htons and cpu_to_be16 unfolds to __swab16 which provides special case for constants. In big endian cases, __constant_htons and htons expand directly to the same expression. The same applies for __constant_cpu_to_be16 and cpu_to_be16. So, replace __constant_htons with htons and __constant_cpu_to_be16 with cpu_to_be16 with the goal of getting rid of the definitions __constant_htons and __constant_cpu_to_be16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ ( - __constant_htons(x) + htons(x) | - __constant_cpu_to_be16(x) + cpu_to_be16(x) ) Signed-off-by: Vaishali Thakkar --- drivers/block/aoe/aoecmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 422b7d8..6e891d2 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c @@ -69,7 +69,7 @@ new_skb(ulong len) skb_reserve(skb, MAX_HEADER); skb_reset_mac_header(skb); skb_reset_network_header(skb); - skb->protocol = __constant_htons(ETH_P_AOE); + skb->protocol = htons(ETH_P_AOE); skb_checksum_none_assert(skb); } return skb; @@ -132,7 +132,7 @@ aoehdr_atainit(struct aoedev *d, struct aoetgt *t, struct aoe_hdr *h) memcpy(h->src, t->ifp->nd->dev_addr, sizeof h->src); memcpy(h->dst, t->addr, sizeof h->dst); - h->type = __constant_cpu_to_be16(ETH_P_AOE); + h->type = cpu_to_be16(ETH_P_AOE); h->verfl = AOE_HVER; h->major = cpu_to_be16(d->aoemajor); h->minor = d->aoeminor; @@ -437,7 +437,7 @@ aoecmd_cfg_pkts(ushort aoemajor, unsigned char aoeminor, struct sk_buff_head *qu memset(h->dst, 0xff, sizeof h->dst); memcpy(h->src, ifp->dev_addr, sizeof h->src); - h->type = __constant_cpu_to_be16(ETH_P_AOE); + h->type = cpu_to_be16(ETH_P_AOE); h->verfl = AOE_HVER; h->major = cpu_to_be16(aoemajor); h->minor = aoeminor; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/