Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750919AbbFSFqX (ORCPT ); Fri, 19 Jun 2015 01:46:23 -0400 Received: from mail-yk0-f169.google.com ([209.85.160.169]:35560 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbbFSFqQ convert rfc822-to-8bit (ORCPT ); Fri, 19 Jun 2015 01:46:16 -0400 MIME-Version: 1.0 In-Reply-To: <5583A87F.5090807@samsung.com> References: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> <5583A87F.5090807@samsung.com> Date: Fri, 19 Jun 2015 14:46:15 +0900 X-Google-Sender-Auth: oFC1Hhic1ziY-p5ws92mwN5vxRw Message-ID: Subject: Re: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj From: Krzysztof Kozlowski To: Inki Dae Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , David Airlie , Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2304 Lines: 64 2015-06-19 14:28 GMT+09:00 Inki Dae : > On 2015년 06월 19일 14:23, Krzysztof Kozlowski wrote: >> The field 'vma' of 'exynos_drm_gem_obj' structure was introduced in >> 2a3098ff6c21 ("drm/exynos: add userptr feature for g2d module") but is >> not referenced anywhere. >> >> One instance of 'exynos_drm_gem_obj' may be mapped to multiple >> user-space VMAs so 'vma' field does not look useful anyway. > > Krzysztof, > > The vma member would be removed by below patch, > http://lists.freedesktop.org/archives/dri-devel/2015-May/082764.html > I think it is a different object. The patch above removes it from struct g2d_cmdlist_userptr. However I removed it from struct exynos_drm_gem_obj, where it was never referenced. Best regards, Krzysztof > Thanks, > Inki Dae > >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.h b/drivers/gpu/drm/exynos/exynos_drm_gem.h >> index 308173cb4f0a..6f42e2248288 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_gem.h >> +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.h >> @@ -61,7 +61,6 @@ struct exynos_drm_gem_buf { >> * or at framebuffer creation. >> * @size: size requested from user, in bytes and this size is aligned >> * in page unit. >> - * @vma: a pointer to vm_area. >> * @flags: indicate memory type to allocated buffer and cache attruibute. >> * >> * P.S. this object would be transferred to user as kms_bo.handle so >> @@ -71,7 +70,6 @@ struct exynos_drm_gem_obj { >> struct drm_gem_object base; >> struct exynos_drm_gem_buf *buffer; >> unsigned long size; >> - struct vm_area_struct *vma; >> unsigned int flags; >> }; >> >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/