Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753557AbbFSGAY (ORCPT ); Fri, 19 Jun 2015 02:00:24 -0400 Received: from mail-am1on0116.outbound.protection.outlook.com ([157.56.112.116]:2172 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752997AbbFSGAF convert rfc822-to-8bit (ORCPT ); Fri, 19 Jun 2015 02:00:05 -0400 From: "Abdul, Hussain (H.)" To: "gregkh@linuxfoundation.org" CC: "abbotti@mev.co.uk" , "hsweeten@visionengravers.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH 2/6] Staging: comedi: fl512: Simplify a trivial if-return sequence Thread-Topic: [PATCH 2/6] Staging: comedi: fl512: Simplify a trivial if-return sequence Thread-Index: AQHQqlUu4rChFhN2702YUxgIP4TIxA== Date: Fri, 19 Jun 2015 06:00:02 +0000 Message-ID: <1434693514-10621-2-git-send-email-habdul@visteon.com> References: <1434693514-10621-1-git-send-email-habdul@visteon.com> In-Reply-To: <1434693514-10621-1-git-send-email-habdul@visteon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 1.9.1 authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [74.112.167.117] x-microsoft-exchange-diagnostics: 1;DB5PR06MB1110;5:KT4YEv6Su7edjmHDErb2bTDecXWFyMSN4nJuIJkeys2EdkyNIKFls40PFVGn/60yIc0AtFwGwCHoMa1/ngrxez2MHioCl6dxU5ARUCeBUbSCfIs6ebeOSspnkTqn92+Z+CUkKnuWkHm6jOthz1o38w==;24:03Wnkj7DaJTPzF7W6p+bKC3lCRaldJHNnmFBT2gIgKIsJ4C3SDyOPYdw7IYz9B+Z0/zZCHRqUGoHXPgYtKACCvJcsvksyfsgqt9fRU8/o30=;20:Fduy69gO5V5WWpDM+Eg35VhIKvy/gUaiKpLme8NE0U4sSoy7T8Yi8HnPlV8msPLZ1H0uTezWaLlBEi6Xbigs5g== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1110; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB5PR06MB1110;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1110; x-forefront-prvs: 0612E553B4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(2950100001)(2900100001)(19580395003)(19580405001)(102836002)(110136002)(77096005)(2501003)(5002640100001)(189998001)(92566002)(33646002)(5890100001)(5001960100002)(106116001)(86362001)(87936001)(2656002)(2351001)(122556002)(46102003)(62966003)(66066001)(77156002)(76176999)(229853001)(50986999)(40100003)(36756003)(50226001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1110;H:DB5PR06MB1112.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2015 06:00:02.8662 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1110 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 34 From: Abdul Hussain This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Signed-off-by: Abdul Hussain --- drivers/staging/comedi/drivers/fl512.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c index e1f4932..55cae61 100644 --- a/drivers/staging/comedi/drivers/fl512.c +++ b/drivers/staging/comedi/drivers/fl512.c @@ -136,11 +136,7 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it) s->range_table = &range_fl512; s->insn_write = fl512_ao_insn_write; - ret = comedi_alloc_subdev_readback(s); - if (ret) - return ret; - - return 0; + return comedi_alloc_subdev_readback(s); } static struct comedi_driver fl512_driver = { -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/