Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753953AbbFSGA5 (ORCPT ); Fri, 19 Jun 2015 02:00:57 -0400 Received: from mail-am1on0125.outbound.protection.outlook.com ([157.56.112.125]:53133 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752995AbbFSGAT convert rfc822-to-8bit (ORCPT ); Fri, 19 Jun 2015 02:00:19 -0400 From: "Abdul, Hussain (H.)" To: "gregkh@linuxfoundation.org" CC: "abbotti@mev.co.uk" , "hsweeten@visionengravers.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH 6/6] Staging: comedi: s626: Simplify a trivial if-return sequence Thread-Topic: [PATCH 6/6] Staging: comedi: s626: Simplify a trivial if-return sequence Thread-Index: AQHQqlU3yjyOwK5ipEaOOkCa9SDrtg== Date: Fri, 19 Jun 2015 06:00:16 +0000 Message-ID: <1434693514-10621-6-git-send-email-habdul@visteon.com> References: <1434693514-10621-1-git-send-email-habdul@visteon.com> In-Reply-To: <1434693514-10621-1-git-send-email-habdul@visteon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 1.9.1 authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [74.112.167.117] x-microsoft-exchange-diagnostics: 1;DB5PR06MB1110;5:ruh+E8jf7buT8MhpD1vv/ujaUps/HSBpSVGp55C1pDq13YIF6OOE9Di3xAcS+nkdfksIzQEpmggCiJ2mndLI1WX3Zr1B6grCdQvL4viAq0ffLTJy+ysJSinl4OfU/GGOSRRgMmRHmpkKobk4UkeH7w==;24:gHsT6RgddwHXxiHMDLgg83Pljb7sk1Ff2ySFfZrJWK+aOLoip+cksC2bmK92PQjZiZ1WtFPyNWLm6uHxDCDO1MzACiFQ2KIuMuVrqH8UE2E=;20:MwdbXKyrCfWXJO/mayDm7XgehfNpC06i4UVWfQyuVd3MbuEDEJrpvPgigX3NiXvQLYACl8FiU4GqrwHaV5w9LA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1110; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB5PR06MB1110;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1110; x-forefront-prvs: 0612E553B4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(2950100001)(2900100001)(19580395003)(19580405001)(102836002)(110136002)(77096005)(2501003)(5002640100001)(189998001)(92566002)(33646002)(5890100001)(5001960100002)(106116001)(575784001)(86362001)(87936001)(2656002)(2351001)(122556002)(46102003)(62966003)(66066001)(77156002)(76176999)(229853001)(50986999)(40100003)(36756003)(50226001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1110;H:DB5PR06MB1112.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2015 06:00:16.6948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1110 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 34 From: Abdul Hussain This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Signed-off-by: Abdul Hussain --- drivers/staging/comedi/drivers/s626.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c index 781918d..35f0f67 100644 --- a/drivers/staging/comedi/drivers/s626.c +++ b/drivers/staging/comedi/drivers/s626.c @@ -2852,11 +2852,7 @@ static int s626_auto_attach(struct comedi_device *dev, s->insn_read = s626_enc_insn_read; s->insn_write = s626_enc_insn_write; - ret = s626_initialize(dev); - if (ret) - return ret; - - return 0; + return s626_initialize(dev); } static void s626_detach(struct comedi_device *dev) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/