Message-ID: <5583C420.4040604@amd.com>
Date: Fri, 19 Jun 2015 09:26:24 +0200
From: =?windows-1252?Q?Christian_K=F6nig?= <christian.koenig@amd.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Maninder Singh <maninder1.s@samsung.com>, <alexander.deucher@amd.com>,
        <airlied@linux.ie>, <dri-devel@lists.freedesktop.org>,
        <linux-kernel@vger.kernel.org>
CC: <pankaj.m@samsung.com>
Subject: Re: [PATCH 1/1] drm/radeon: use kzalloc for allocating one thing
References: <1434686723-12936-1-git-send-email-maninder1.s@samsung.com>
In-Reply-To: <1434686723-12936-1-git-send-email-maninder1.s@samsung.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 8BIT
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2015 07:26:29.1797
 (UTC)
X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1476
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1457;2:qtcxiDw0YpF/+cLERgvxb6MPRHI/jVZdd9tnWQWRSI+LW7MJu+EHIz41zu/+x4rU;2:V5AX/AUG769nKjxqUJRzCL33KSHugObnYfluuhO1GPlM1lAbZwiObl/A1wpcwKFmz6uzr4+xGc1cF3SjQ8Xpa1Gb/tHSLE+TlnvTRWEqu59WpgEpn1mjGl0mPu9j1g+w4z/Nwvi3aQStV0D3kw9+DLz7eON5IaWlsGuhpruG+8KWiuUHSsbj07M7rPdwR+8dXtRVi2Gmo4n3BcuBxfFmmGxX241M3TO2vfRNr5klxbZF1SNZWBK02M3Ol5abqmXq;9:NG5kCEA4xAuJj9xnO4H0hIn8TKr9c1v2dls+oWre8z++0ES6aOZnfRi+Vx/89jmYhUsk/pylE4GoS7TcvdkRI6d8vhXhqC+xz1zunQvBB4wKHDLxBPfEhe+w/yWQIAhrrnfKntAX3iMQGa83GxlHng==
X-OriginatorOrg: amd.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1359
Lines: 48

On 19.06.2015 06:05, Maninder Singh wrote:
> Use kzalloc for allocating one thing rather than
> kcalloc(1...
>
> The semantic patch that makes this change is as follows:
>
> // <smpl>
> @@
> @@
>
> - kcalloc(1,
> + kzalloc(
>            ...)
> // </smpl>
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>

Reviewed-by: Christian K?nig <christian.koenig@amd.com>

Alex should pick that up in his 4.2 branch.

Regards,
Christian.

> ---
>   drivers/gpu/drm/radeon/radeon_ttm.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index edafd3c..06ac59f 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -719,7 +719,7 @@ static int radeon_ttm_tt_populate(struct ttm_tt *ttm)
>   		return 0;
>   
>   	if (gtt && gtt->userptr) {
> -		ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL);
> +		ttm->sg = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
>   		if (!ttm->sg)
>   			return -ENOMEM;
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/