Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754204AbbFSHeq (ORCPT ); Fri, 19 Jun 2015 03:34:46 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:41214 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbbFSHek (ORCPT ); Fri, 19 Jun 2015 03:34:40 -0400 Message-ID: <1434699273.2385.139.camel@x220> Subject: Re: [PATCH v2 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit From: Paul Bolle To: Cyrille Pitchen Cc: nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, alexandre.belloni@free-electrons.com, sameo@linux.intel.com, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Date: Fri, 19 Jun 2015 09:34:33 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1099 Lines: 30 On Thu, 2015-06-18 at 15:05 +0200, Cyrille Pitchen wrote: > --- /dev/null > +++ b/drivers/mfd/atmel-flexcom.c > +MODULE_ALIAS("platform:atmel_flexcom"); (The day before yesterday and yesterday I had a, well, lively conversation regarding this macro. The interesting bits start at https://lkml.org/lkml/2015/6/17/383 . Let's see how things go here.) As I understand it, this alias is only useful if there's a corresponding struct platform_device, somewhere. Ie, this alias implies a platform_device that will fire of a "MODALIAS=platform:atmel_flexcom" uevent when it's created. That would be a platform_device using a "atmel_flexcom" name. If that's correct, then I think this MODULE_ALIAS macro isn't needed here, as I couldn't find a platform_device using that name. (But perhaps a patch that adds it is pending, somewhere.) Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/