Message-ID: <5583D130.5080207@linaro.org>
Date: Fri, 19 Jun 2015 09:22:08 +0100
From: Daniel Thompson <daniel.thompson@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Sagar Dharia <sdharia@codeaurora.org>, gregkh@linuxfoundation.org,
        bp@suse.de, poeschel@lemonage.de, treding@nvidia.com,
        broonie@kernel.org, gong.chen@linux.intel.com,
        andreas.noever@gmail.com, alan@linux.intel.com,
        mathieu.poirier@linaro.org, daniel@ffwll.ch, oded.gabbay@amd.com,
        jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com,
        davem@davemloft.net, james.hogan@imgtec.com,
        michael.opdenacker@free-electrons.com, linux-kernel@vger.kernel.org
CC: nkaje@codeaurora.org, kheitke@audience.com, mlocke@codeaurora.org,
        agross@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V2 1/6] SLIMbus: Device management on SLIMbus
References: <1434505564-14333-1-git-send-email-sdharia@codeaurora.org> <1434505564-14333-2-git-send-email-sdharia@codeaurora.org>
In-Reply-To: <1434505564-14333-2-git-send-email-sdharia@codeaurora.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1148
Lines: 33

On 17/06/15 02:45, Sagar Dharia wrote:
> --- /dev/null
> +++ b/drivers/slimbus/Kconfig
> @@ -0,0 +1,9 @@
> +#
> +# SLIMBUS driver configuration
> +#
> +menuconfig SLIMBUS
> +	tristate "Slimbus support"
> +	help
> +	  Slimbus is standard interface between baseband and audio codec,
> +	  and other peripheral components in mobile terminals.

Perhaps this is a fussy comment but this description of slimbus makes 
pretty heavy use of mobile phone jargon. Admittedly it is jargon from 
the slimbus spec which, as standards go, seems rather myopic about its 
potential user base.

However, even the standards own self-description doesn't limit its role 
to baseband <-> peripherals. What happened to the application 
processor/main-SoC?

Also would an "If unsure, choose N." be useful? It could be quite a long 
time before someone who doesn't know they need slimbus actually finds 
that they do.


Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/