Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754557AbbFSIgO (ORCPT ); Fri, 19 Jun 2015 04:36:14 -0400 Received: from mail-qg0-f43.google.com ([209.85.192.43]:36199 "EHLO mail-qg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754509AbbFSIgE (ORCPT ); Fri, 19 Jun 2015 04:36:04 -0400 MIME-Version: 1.0 X-Originating-IP: [217.173.38.102] In-Reply-To: <20150619082928.GJ17109@ZenIV.linux.org.uk> References: <20150618133215.12722.70352.stgit@warthog.procyon.org.uk> <20150619072015.GH17109@ZenIV.linux.org.uk> <20150619075903.GI17109@ZenIV.linux.org.uk> <20150619081128.GA24181@tucsk> <20150619082928.GJ17109@ZenIV.linux.org.uk> Date: Fri, 19 Jun 2015 10:36:03 +0200 Message-ID: Subject: Re: [PATCH 0/8] Security: Provide unioned file support From: Miklos Szeredi To: Al Viro Cc: David Howells , sds@tycho.nsa.gov, Linux-Fsdevel , linux-security-module@vger.kernel.org, "linux-unionfs@vger.kernel.org" , Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 784 Lines: 22 On Fri, Jun 19, 2015 at 10:29 AM, Al Viro wrote: > Directory, probably? > >> - dentry = lookup_one_len(name, parent->dentry, namelen); >> + dentry = lookup_one_len(name, parent, namelen); > > ... it would better be one. My point is: without a bloody accessor, there's no way to warn if the use is illegal (i.e. nondirectory). Maybe we won't need file->f_dentry, but we do need a way to WARN about abuse (which there IS probably a significant number already and nothing preventing more). Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/