Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754678AbbFSJCu (ORCPT ); Fri, 19 Jun 2015 05:02:50 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36299 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753771AbbFSJCk (ORCPT ); Fri, 19 Jun 2015 05:02:40 -0400 MIME-Version: 1.0 In-Reply-To: <20150619083410.GA2885@lst.de> References: <20150617235209.12943.24419.stgit@dwillia2-desk3.amr.corp.intel.com> <20150617235551.12943.76656.stgit@dwillia2-desk3.amr.corp.intel.com> <20150619083410.GA2885@lst.de> Date: Fri, 19 Jun 2015 02:02:39 -0700 Message-ID: Subject: Re: [PATCH 12/15] libnvdimm: enable iostat From: Dan Williams To: Christoph Hellwig Cc: Jens Axboe , "linux-nvdimm@lists.01.org" , Boaz Harrosh , "Kani, Toshimitsu" , Vishal Verma , "linux-kernel@vger.kernel.org" , Linux ACPI , linux-fsdevel , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 16 On Fri, Jun 19, 2015 at 1:34 AM, Christoph Hellwig wrote: > On Wed, Jun 17, 2015 at 07:55:51PM -0400, Dan Williams wrote: >> This is disabled by default as the overhead is prohibitive, but if the >> user takes the action to turn it on we'll oblige. > > If you care about users a compile time selection doesn't make sense, > why not always build it but require an opt-in? It's always built the Kconfig just selects the default initial state of QUEUE_FLAG_IO_STAT. They can always turn it on/off via block queue sysfs. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/