Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbbFSJZ3 (ORCPT ); Fri, 19 Jun 2015 05:25:29 -0400 Received: from www.linutronix.de ([62.245.132.108]:57195 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753038AbbFSJZW (ORCPT ); Fri, 19 Jun 2015 05:25:22 -0400 Date: Fri, 19 Jun 2015 11:25:21 +0200 (CEST) From: Thomas Gleixner To: Sergey Senozhatsky cc: Jiang Liu , Borislav Petkov , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [-next] !irqd_can_balance() WARNINGs at irq_move_masked_irq() In-Reply-To: <20150619071123.GA511@swordfish> Message-ID: References: <20150619071123.GA511@swordfish> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1699 Lines: 53 On Fri, 19 Jun 2015, Sergey Senozhatsky wrote: > [ 0.412291] WARNING: CPU: 0 PID: 0 at kernel/irq/migration.c:21 irq_move_masked_irq+0x57/0xc4() > [ 0.412371] Can't balance irq 0 [edge] Yuck. > Do you guys want to replace WAN_ON() with WARN_ONCE(), perhaps? This, of course, > doesn't fix anything; but at least one can boot the system. (not really a patch, > just an idea). Indeed. We really want to clear the move pending bit before the can balance check. Patch below. But that does not explain why this happens in the first place. Can you please send me a full dmesg, kernel config and output of /proc/interrupts ? (Private mail is fine, or upload it to some place) Thanks, tglx --- diff --git a/kernel/irq/migration.c b/kernel/irq/migration.c index dd203e276b07..8cf8c24afaab 100644 --- a/kernel/irq/migration.c +++ b/kernel/irq/migration.c @@ -12,16 +12,19 @@ void irq_move_masked_irq(struct irq_data *idata) if (likely(!irqd_is_setaffinity_pending(&desc->irq_data))) return; + irqd_clr_move_pending(&desc->irq_data); + /* * Paranoia: cpu-local interrupts shouldn't be calling in here anyway. */ if (!irqd_can_balance(&desc->irq_data)) { - WARN_ON(1); + pr_warn("Cannot move irq %d: %s\n", + desc->irq_data.irq, + irqd_is_per_cpu(&desc->irq_data) ? + "per cpu" : "balancing disabled"); return; } - irqd_clr_move_pending(&desc->irq_data); - if (unlikely(cpumask_empty(desc->pending_mask))) return; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/