Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754864AbbFSKw3 (ORCPT ); Fri, 19 Jun 2015 06:52:29 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33311 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754706AbbFSKwV (ORCPT ); Fri, 19 Jun 2015 06:52:21 -0400 Message-ID: <5583F45C.2070708@linaro.org> Date: Fri, 19 Jun 2015 18:52:12 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Al Stone , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org CC: rjw@rjwysocki.net, lenb@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, linaro-kernel@lists.linaro.org, patches@linaro.org Subject: Re: [PATCH v2 3/3] ACPI / ARM64 : use the new BAD_MADT_GICC_ENTRY macro References: <1434666968-1543-1-git-send-email-al.stone@linaro.org> <1434666968-1543-4-git-send-email-al.stone@linaro.org> In-Reply-To: <1434666968-1543-4-git-send-email-al.stone@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 45 On 06/19/2015 06:36 AM, Al Stone wrote: > For those parts of the arm64 ACPI code that need to check GICC subtables > in the MADT, use the new BAD_MADT_GICC_ENTRY macro instead of the previous > BAD_MADT_ENTRY. The new macro takes into account differences in the size > of the GICC subtable that the old macro did not; this caused failures even > though the subtable entries are valid. > > Signed-off-by: Al Stone > --- > arch/arm64/kernel/smp.c | 2 +- > drivers/irqchip/irq-gic.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 4b2121b..80d5984 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -438,7 +438,7 @@ acpi_parse_gic_cpu_interface(struct acpi_subtable_header *header, > struct acpi_madt_generic_interrupt *processor; > > processor = (struct acpi_madt_generic_interrupt *)header; > - if (BAD_MADT_ENTRY(processor, end)) > + if (BAD_MADT_GICC_ENTRY(processor, end)) > return -EINVAL; > > acpi_table_print_madt_entry(header); > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > index 8d7e1c8..4dd8826 100644 > --- a/drivers/irqchip/irq-gic.c > +++ b/drivers/irqchip/irq-gic.c > @@ -1055,7 +1055,7 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header, > > processor = (struct acpi_madt_generic_interrupt *)header; > > - if (BAD_MADT_ENTRY(processor, end)) > + if (BAD_MADT_GICC_ENTRY(processor, end)) > return -EINVAL; Reviewed-by: Hanjun Guo Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/