Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580AbbFSM3o (ORCPT ); Fri, 19 Jun 2015 08:29:44 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:37827 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbbFSM3e (ORCPT ); Fri, 19 Jun 2015 08:29:34 -0400 MIME-Version: 1.0 Reply-To: cw00.choi@samsung.com In-Reply-To: <1434709467-28147-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> References: <1434709467-28147-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434709467-28147-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> Date: Fri, 19 Jun 2015 21:29:34 +0900 Message-ID: Subject: Re: [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state From: Chanwoo Choi To: Charles Keepax Cc: "myungjoo.ham@samsung.com" , linux-kernel , patches@opensource.wolfsonmicro.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2050 Lines: 53 Hi Charles, I'm sorry about lack of my commet on previous patch. I just want to know the what is meaning of zero(0) index of "info->micd_modes[0] array" instead of separate variable (gpio_initial_level). So, I'd like you to drop this patch on next your patch-set. Thanks, Chanwoo Choi On Fri, Jun 19, 2015 at 7:24 PM, Charles Keepax wrote: > Signed-off-by: Charles Keepax > --- > drivers/extcon/extcon-arizona.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index 9262b45..e31613a 100644 > --- a/drivers/extcon/extcon-arizona.c > +++ b/drivers/extcon/extcon-arizona.c > @@ -1135,6 +1135,7 @@ static int arizona_extcon_probe(struct platform_device *pdev) > struct arizona *arizona = dev_get_drvdata(pdev->dev.parent); > struct arizona_pdata *pdata = &arizona->pdata; > struct arizona_extcon_info *info; > + int gpio_initial_level; > unsigned int val; > unsigned int clamp_mode; > int jack_irq_fall, jack_irq_rise; > @@ -1226,8 +1227,9 @@ static int arizona_extcon_probe(struct platform_device *pdev) > info->micd_num_modes = ARRAY_SIZE(micd_default_modes); > } > > + gpio_initial_level = info->micd_modes[0].gpio; > if (arizona->pdata.micd_pol_gpio > 0) { > - if (info->micd_modes[0].gpio) > + if (gpio_initial_level) > mode = GPIOF_OUT_INIT_HIGH; > else > mode = GPIOF_OUT_INIT_LOW; > -- > 1.7.2.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/