Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932261AbbFSSUL (ORCPT ); Fri, 19 Jun 2015 14:20:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35459 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932179AbbFSSUH (ORCPT ); Fri, 19 Jun 2015 14:20:07 -0400 Date: Fri, 19 Jun 2015 20:18:55 +0200 From: Oleg Nesterov To: Al Viro , Andrew Morton , Benjamin LaHaise , Jeff Moyer Cc: linux-aio@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/3] aio_ring_remap: kill the bogus ctx->dead check Message-ID: <20150619181855.GA20796@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150619181840.GA20780@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 38 kill_ioctx() sets ctx->dead and removes ctx from ->ioctx_table "atomically" under mm->ioctx_lock, so aio_ring_remap() can never see a dead ctx. Signed-off-by: Oleg Nesterov Reviewed-by: Jeff Moyer --- fs/aio.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index 480440f..893d300 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -325,14 +325,11 @@ static int aio_ring_remap(struct file *file, struct vm_area_struct *vma) rcu_read_lock(); table = rcu_dereference(mm->ioctx_table); for (i = 0; i < table->nr; i++) { - struct kioctx *ctx; + struct kioctx *ctx = table->table[i]; - ctx = table->table[i]; if (ctx && ctx->aio_ring_file == file) { - if (!atomic_read(&ctx->dead)) { - ctx->user_id = ctx->mmap_base = vma->vm_start; - res = 0; - } + ctx->user_id = ctx->mmap_base = vma->vm_start; + res = 0; break; } } -- 1.5.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/