Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932179AbbFSUCF (ORCPT ); Fri, 19 Jun 2015 16:02:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58419 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbbFSUBt (ORCPT ); Fri, 19 Jun 2015 16:01:49 -0400 Message-ID: <55847529.10702@redhat.com> Date: Fri, 19 Jun 2015 14:01:45 -0600 From: Al Stone User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Hanjun Guo , Al Stone , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org CC: rjw@rjwysocki.net, lenb@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, linaro-kernel@lists.linaro.org, patches@linaro.org Subject: Re: [PATCH v2 1/3] ACPI : introduce macros for using the ACPI specification version References: <1434666968-1543-1-git-send-email-al.stone@linaro.org> <1434666968-1543-2-git-send-email-al.stone@linaro.org> <5583F3A7.4020202@linaro.org> In-Reply-To: <5583F3A7.4020202@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2047 Lines: 68 On 06/19/2015 04:49 AM, Hanjun Guo wrote: > On 06/19/2015 06:36 AM, Al Stone wrote: >> Add the ACPI_SPEC_VERSION() macro to build a proper version number from >> a major and minor revision number. Add also the ACPI_FADT_SPEC_VERSION >> that constructs a proper version number from the entries in the current >> FADT. >> >> These macros are added in order to simplify retrieving and comparing ACPI >> specification version numbers, since this is becoming a more frequent need. >> In particular, there are some architectures that require at least a certain >> version of the spec, and there are differences in some structure sizes that >> have changed with recent versions but can only be tracked by spec version >> number. >> >> Signed-off-by: Al Stone >> --- >> include/linux/acpi.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/linux/acpi.h b/include/linux/acpi.h >> index a4acb55..33ed313 100644 >> --- a/include/linux/acpi.h >> +++ b/include/linux/acpi.h >> @@ -48,6 +48,11 @@ >> #include >> #include >> >> +#define ACPI_SPEC_VERSION(major, minor) ((major<<8)|minor) > > and minor comments for code style > > ((major<<8)|minor) - > ((major << 8) | minor) Ah. Yeah, good idea. I can roll that into next version. > other than that: > > Reviewed-by: Hanjun Guo Thanks. > Thanks > Hanjun > >> +#define ACPI_FADT_SPEC_VERSION \ >> + ACPI_SPEC_VERSION(acpi_gbl_FADT.header.revision, \ >> + acpi_gbl_FADT.minor_revision) >> + >> static inline acpi_handle acpi_device_handle(struct acpi_device *adev) >> { >> return adev ? adev->handle : NULL; >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in -- ciao, al ----------------------------------- Al Stone Software Engineer Red Hat, Inc. ahs3@redhat.com ----------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/