Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754725AbbFSUEC (ORCPT ); Fri, 19 Jun 2015 16:04:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35280 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbbFSUDy (ORCPT ); Fri, 19 Jun 2015 16:03:54 -0400 Message-ID: <558475A7.6050209@redhat.com> Date: Fri, 19 Jun 2015 14:03:51 -0600 From: Al Stone User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Will Deacon , Al Stone CC: "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , Catalin Marinas , "tglx@linutronix.de" , "jason@lakedaemon.net" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "linaro-kernel@lists.linaro.org" , "patches@linaro.org" Subject: Re: [PATCH v2 3/3] ACPI / ARM64 : use the new BAD_MADT_GICC_ENTRY macro References: <1434666968-1543-1-git-send-email-al.stone@linaro.org> <1434666968-1543-4-git-send-email-al.stone@linaro.org> <20150619094658.GB18017@arm.com> In-Reply-To: <20150619094658.GB18017@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2247 Lines: 70 On 06/19/2015 03:46 AM, Will Deacon wrote: > On Thu, Jun 18, 2015 at 11:36:08PM +0100, Al Stone wrote: >> For those parts of the arm64 ACPI code that need to check GICC subtables >> in the MADT, use the new BAD_MADT_GICC_ENTRY macro instead of the previous >> BAD_MADT_ENTRY. The new macro takes into account differences in the size >> of the GICC subtable that the old macro did not; this caused failures even >> though the subtable entries are valid. >> >> Signed-off-by: Al Stone >> --- >> arch/arm64/kernel/smp.c | 2 +- >> drivers/irqchip/irq-gic.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Will Deacon > > Good to see this stuff is holding up so well... > > Will Thanks, Will. >> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c >> index 4b2121b..80d5984 100644 >> --- a/arch/arm64/kernel/smp.c >> +++ b/arch/arm64/kernel/smp.c >> @@ -438,7 +438,7 @@ acpi_parse_gic_cpu_interface(struct acpi_subtable_header *header, >> struct acpi_madt_generic_interrupt *processor; >> >> processor = (struct acpi_madt_generic_interrupt *)header; >> - if (BAD_MADT_ENTRY(processor, end)) >> + if (BAD_MADT_GICC_ENTRY(processor, end)) >> return -EINVAL; >> >> acpi_table_print_madt_entry(header); >> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c >> index 8d7e1c8..4dd8826 100644 >> --- a/drivers/irqchip/irq-gic.c >> +++ b/drivers/irqchip/irq-gic.c >> @@ -1055,7 +1055,7 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header, >> >> processor = (struct acpi_madt_generic_interrupt *)header; >> >> - if (BAD_MADT_ENTRY(processor, end)) >> + if (BAD_MADT_GICC_ENTRY(processor, end)) >> return -EINVAL; >> >> /* >> -- >> 2.4.0 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- ciao, al ----------------------------------- Al Stone Software Engineer Red Hat, Inc. ahs3@redhat.com ----------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/