Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753089AbbFSUKc (ORCPT ); Fri, 19 Jun 2015 16:10:32 -0400 Received: from mail.kernel.org ([198.145.29.136]:46535 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbbFSUK0 (ORCPT ); Fri, 19 Jun 2015 16:10:26 -0400 Date: Fri, 19 Jun 2015 17:10:21 -0300 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: "Wangnan (F)" , Hou Pengyang , mingo@redhat.com, namhyung@kernel.org, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org Subject: Re: [RFC] perf report: introduce --map-anon-mem for anon-executable-memory symbols parsing Message-ID: <20150619201021.GG31188@kernel.org> References: <1434636076-13502-1-git-send-email-houpengyang@huawei.com> <5583E088.6080202@huawei.com> <20150619104214.GA3298@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150619104214.GA3298@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 33 Em Fri, Jun 19, 2015 at 12:42:14PM +0200, Ingo Molnar escreveu: > * Wangnan (F) wrote: > > > On 2015/6/18 22:01, Hou Pengyang wrote: > > >This patch introduces a --map-anon-mem argument to perf report to deal > > >with anon-executable-memory symbol parsing. > > > > --map-anon-mem is not a good name. The user defined map area list > > introduced in this patch can be used on not only anon mapping but > > also file mapping. > > Yeah, so quirky options generally suck and only 0.01% of the users will use it. > It's in a way worse than not having this code, because we'll have to maintain it, > but it won't be used. > > Is there a way to auto-detect 'executable anon mappings' (perhaps by generating an > MMAP event with some extra bit set, or a new MMAP event?) so that it's all > seemless? > > The user should not be required to know about such details! Also I think we shouldn't have two maps instances, i.e. if one wants to insert some "map files", i.e. details about a map on a file, csv or any other format (JSON anyone? :-)), or like he did, on the command line, then it should be added to the existing per thread tree of maps, i.e. would be useful for some super specialized corner case but wouldn't impact the common case, i.e. no try this tree of maps, if it is not there, then try the other, that everybody else uses, etc. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/