Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932385AbbFTAvx (ORCPT ); Fri, 19 Jun 2015 20:51:53 -0400 Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:44191 "HELO gproxy4-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754605AbbFTAvq (ORCPT ); Fri, 19 Jun 2015 20:51:46 -0400 X-Greylist: delayed 399 seconds by postgrey-1.27 at vger.kernel.org; Fri, 19 Jun 2015 20:51:46 EDT X-Authority-Analysis: v=2.1 cv=Bb1LjNd2 c=1 sm=1 tr=0 a=6lV6tj8ir7tGSl/9xQZNPA==:117 a=6lV6tj8ir7tGSl/9xQZNPA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=FurB0epzNeMA:10 a=N659UExz7-8A:10 a=N54-gffFAAAA:8 a=05RPwmwRPNYA:10 a=I4ko-sDDNxYA:10 a=XAFQembCKUMA:10 a=pGLkceISAAAA:8 a=XBJSIkjVqm11LYF4XrwA:9 a=pILNOxqGKmIA:10 Message-ID: <5584B78C.4060000@acm.org> Date: Fri, 19 Jun 2015 20:45:00 -0400 From: Ed Cashin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Vaishali Thakkar CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] aoe: Convert use of __constant_ to References: <20150619031505.GA17748@vaishali-Ideapad-Z570> In-Reply-To: <20150619031505.GA17748@vaishali-Ideapad-Z570> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Identified-User: {2969:box320.bluehost.com:cashinwo:cashinworks.com} {sentby:smtp auth 98.192.52.118 authed with ed@cashinworks.com} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2260 Lines: 65 OK. Thanks. On 06/18/2015 11:15 PM, Vaishali Thakkar wrote: > In little endian cases, the macros htons and cpu_to_be16 unfolds > to __swab16 which provides special case for constants. In big > endian cases, __constant_htons and htons expand directly to the > same expression. The same applies for __constant_cpu_to_be16 and > cpu_to_be16. > > So, replace __constant_htons with htons and __constant_cpu_to_be16 > with cpu_to_be16 with the goal of getting rid of the definitions > __constant_htons and __constant_cpu_to_be16 completely. > > The semantic patch that performs this transformation is as follows: > > @@expression x;@@ > > ( > - __constant_htons(x) > + htons(x) > | > - __constant_cpu_to_be16(x) > + cpu_to_be16(x) > ) > > Signed-off-by: Vaishali Thakkar > --- > drivers/block/aoe/aoecmd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c > index 422b7d8..6e891d2 100644 > --- a/drivers/block/aoe/aoecmd.c > +++ b/drivers/block/aoe/aoecmd.c > @@ -69,7 +69,7 @@ new_skb(ulong len) > skb_reserve(skb, MAX_HEADER); > skb_reset_mac_header(skb); > skb_reset_network_header(skb); > - skb->protocol = __constant_htons(ETH_P_AOE); > + skb->protocol = htons(ETH_P_AOE); > skb_checksum_none_assert(skb); > } > return skb; > @@ -132,7 +132,7 @@ aoehdr_atainit(struct aoedev *d, struct aoetgt *t, struct aoe_hdr *h) > > memcpy(h->src, t->ifp->nd->dev_addr, sizeof h->src); > memcpy(h->dst, t->addr, sizeof h->dst); > - h->type = __constant_cpu_to_be16(ETH_P_AOE); > + h->type = cpu_to_be16(ETH_P_AOE); > h->verfl = AOE_HVER; > h->major = cpu_to_be16(d->aoemajor); > h->minor = d->aoeminor; > @@ -437,7 +437,7 @@ aoecmd_cfg_pkts(ushort aoemajor, unsigned char aoeminor, struct sk_buff_head *qu > > memset(h->dst, 0xff, sizeof h->dst); > memcpy(h->src, ifp->dev_addr, sizeof h->src); > - h->type = __constant_cpu_to_be16(ETH_P_AOE); > + h->type = cpu_to_be16(ETH_P_AOE); > h->verfl = AOE_HVER; > h->major = cpu_to_be16(aoemajor); > h->minor = aoeminor; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/