Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755276AbbFTApf (ORCPT ); Fri, 19 Jun 2015 20:45:35 -0400 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:43885 "HELO gproxy9-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753660AbbFTAp0 (ORCPT ); Fri, 19 Jun 2015 20:45:26 -0400 X-Authority-Analysis: v=2.1 cv=Bb1LjNd2 c=1 sm=1 tr=0 a=6lV6tj8ir7tGSl/9xQZNPA==:117 a=6lV6tj8ir7tGSl/9xQZNPA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=FurB0epzNeMA:10 a=N659UExz7-8A:10 a=N54-gffFAAAA:8 a=05RPwmwRPNYA:10 a=I4ko-sDDNxYA:10 a=XAFQembCKUMA:10 a=pGLkceISAAAA:8 a=lEEzpkQo45AJ3_9Mi3YA:9 a=pILNOxqGKmIA:10 Message-ID: <5584B79F.9080004@acm.org> Date: Fri, 19 Jun 2015 20:45:19 -0400 From: Ed Cashin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Vaishali Thakkar CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] aoe: Convert use of __constant_htons to htons References: <20150619032323.GA18667@vaishali-Ideapad-Z570> In-Reply-To: <20150619032323.GA18667@vaishali-Ideapad-Z570> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Identified-User: {2969:box320.bluehost.com:cashinwo:cashinworks.com} {sentby:smtp auth 98.192.52.118 authed with ed@cashinworks.com} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 38 OK. Thanks. On 06/18/2015 11:23 PM, Vaishali Thakkar wrote: > In little endian cases, the macro htons unfolds to __swab16 which > provides special case for constants. In big endian cases, > __constant_htons and htons expand directly to the same expression. > So, replace __constant_htons with htons with the goal of getting > rid of the definition of __constant_htons completely. > > The semantic patch that performs this transformation is as follows: > > @@expression x;@@ > > - __constant_htons(x) > + htons(x) > > Signed-off-by: Vaishali Thakkar > --- > drivers/block/aoe/aoenet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c > index 63773a9..78ff47a 100644 > --- a/drivers/block/aoe/aoenet.c > +++ b/drivers/block/aoe/aoenet.c > @@ -192,7 +192,7 @@ exit: > } > > static struct packet_type aoe_pt __read_mostly = { > - .type = __constant_htons(ETH_P_AOE), > + .type = htons(ETH_P_AOE), > .func = aoenet_rcv, > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/