From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>
To: Graham Moore <grmoore@opensource.altera.com>,
        Anurag Kumar Vulisha <anuragku@xilinx.com>
CC: "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "computersforpeace@gmail.com" <computersforpeace@gmail.com>,
        "marex@denx.de" <marex@denx.de>,
        "shijie.huang@intel.com" <shijie.huang@intel.com>,
        "zajec5@gmail.com" <zajec5@gmail.com>,
        "ben@decadent.org.uk" <ben@decadent.org.uk>,
        "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        =?utf-8?B?IkJlYW4gSHVvIOmcjeaWjOaWjCAoYmVhbmh1byki?= 
	<beanhuo@micron.com>,
        Harini Katakam <harinik@xilinx.com>,
        Anurag Kumar Vulisha <anuragku@xilinx.com>,
        Srikanth Vemula <svemula@xilinx.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        Anirudha Sarangi <anirudh@xilinx.com>,
        Michal Simek <michals@xilinx.com>,
        "Mark Brown (broonie@kernel.org)" <broonie@kernel.org>
Subject: RE: [RFC PATCH] mtd: spi-nor: Added flag check for quad io protocol
 for micron flash parts
Thread-Topic: [RFC PATCH] mtd: spi-nor: Added flag check for quad io
 protocol for micron flash parts
Thread-Index: AQHQqddTRV92zi+jfE2lDVi8ELZSpJ2zra8AgADfDzA=
Date: Sat, 20 Jun 2015 02:30:01 +0000
Message-ID: <03CA77BA8AF6F1469AEDFBDA1322A7B7495B3042@XAP-PVEXMBX02.xlnx.xilinx.com>
References: <1434639539-7517-1-git-send-email-anuragku@xilinx.com>
 <5584695E.1090906@opensource.altera.com>
In-Reply-To: <5584695E.1090906@opensource.altera.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2015 02:30:08.9098
 (UTC)
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB050
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id t5K2Udlb030086
Content-Length: 4547
Lines: 118

Hi Graham,

> -----Original Message-----
> From: Graham Moore [mailto:grmoore@opensource.altera.com]
> Sent: Saturday, June 20, 2015 12:41 AM
> To: Anurag Kumar Vulisha
> Cc: dwmw2@infradead.org; computersforpeace@gmail.com;
> marex@denx.de; shijie.huang@intel.com; zajec5@gmail.com;
> ben@decadent.org.uk; mika.westerberg@linux.intel.com; "Bean Huo 霍斌
> 斌 (beanhuo)"; Harini Katakam; Anurag Kumar Vulisha; Srikanth Vemula;
> linux-kernel@vger.kernel.org; broonie@kernel.org; linux-
> mtd@lists.infradead.org; Anirudha Sarangi; Punnaiah Choudary Kalluri
> Subject: Re: [RFC PATCH] mtd: spi-nor: Added flag check for quad io protocol
> for micron flash parts
> 
> Hi Anurag,
> 
> We're struggling with the same issue, our Cadence QSPI controller *does*
> handle four-line command, address, and data, but has to be configured
> for it.  The setting of quad-io-protocol mode in micron_quad_enable is
> really jacking up our code.  We have to snoop the command stream and
> configure the controller as soon as we see the quad-io-protocol command
> go to the Micron chip.  Ugly.
> 
> I'd like to point out that this flag is also dependent upon the
> particular controller in use, not just the Micron chip.  In fact, it may
> be more of a controller thing than a chip thing.

Agree,
QUAD IO protocol is different to supporting QUAD IO read command.
In QUAD IO Protocol mode, all the commands including register read, erase, read,
Program... will be using the four lines.

Enabling the QUAD IO Protocol in flash should ensure that both the controller
and flash have this support otherwise the result is unpredictable.

So, now m25p80 driver should check the number bits to use depending on the 
Protocol it uses. Literally we need another mode i.e protocol mode.
The possible values for this modes are

Dual Io protocol - all the commands will be sent using 2 lines

Quad Io protocol - all the commands will be send using 4 lines.

Extended spi protocol - number of data lines to use will depends on the data command.

If the protocol is extended spi protocol, m25p80 should select the rx and tx bits to use
for data operations depends on the "mode" i.e. quad/dual
If the protocol is Quad IO/dual Io, m2p80 should select the rx and tx bits either 4/2 for
All the commands.     

Data operations in the above context means read, page program operation.     

 Suggest if we have any other acceptable solutions for implementing the quad/dual io
Protocol support.  

Regards,
Punnaiah 

> 
> Maybe this flag should actually be an enum read_mode value, and passed
> into spi_nor_scan by the controller?
> 
> Thanks,
> Graham
> 
> 
> On 06/18/2015 09:58 AM, Anurag Kumar Vulisha wrote:
> > micron flash parts by default operates in extended spi protocol,which
> accepts
> > command on single line and can accept address & data on one,two and four
> lines
> > depending on the command sent.In set_quad_enable() we are enabling
> the quad io
> > protocol for micron flash parts by updating the EVCR register,in this method
> the
> > flash expects the command,address and data to be transmitted on all four
> data
> > lines which may not be supported on all qspi controllers.So READ_1_1_4
> command
> > does not necessarily go out using those bus widths.
> >
> > So i have added SPI_QUAD_IO_PROTOCOL flag,which should be checked
> before enabling
> > the quad io protocol.
> >
> > Signed-off-by: Anurag Kumar Vulisha <anuragku@xilinx.com>
> > ---
> >   drivers/mtd/spi-nor/spi-nor.c |    3 +++
> >   1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 14a5d23..a6fa8dc 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -55,6 +55,7 @@ struct flash_info {
> >   #define	SPI_NOR_DUAL_READ	0x20    /* Flash supports Dual Read */
> >   #define	SPI_NOR_QUAD_READ	0x40    /* Flash supports Quad Read
> */
> >   #define	USE_FSR			0x80	/* use flag status
> register */
> > +#define SPI_QUAD_IO_PROTOCOL	0x100	/* use quad io protocol */
> >   };
> >
> >   #define JEDEC_MFR(info)	((info)->id[0])
> > @@ -962,6 +963,8 @@ static int set_quad_mode(struct spi_nor *nor,
> struct flash_info *info)
> >   		}
> >   		return status;
> >   	case CFI_MFR_ST:
> > +		if (!(info->flags & SPI_QUAD_IO_PROTOCOL))
> > +			return 0;
> >   		status = micron_quad_enable(nor);
> >   		if (status) {
> >   			dev_err(nor->dev, "Micron quad-read not
> enabled\n");
> >
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????s?y??杶????i??????????i