Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbbFTHnv (ORCPT ); Sat, 20 Jun 2015 03:43:51 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33916 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbbFTHnn (ORCPT ); Sat, 20 Jun 2015 03:43:43 -0400 Date: Sat, 20 Jun 2015 13:13:35 +0530 From: Sudip Mukherjee To: Juston Li Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: sm750fb: use tabs for indentation Message-ID: <20150620074335.GB15195@sudip-PC> References: <1434779457-18601-1-git-send-email-juston.h.li@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434779457-18601-1-git-send-email-juston.h.li@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 30 On Fri, Jun 19, 2015 at 10:50:57PM -0700, Juston Li wrote: > Replace spaces with tabs for indentation to fix the checkpatch.pl warning > 'WARNING: please, no spaces at the start of a line' > > checkpatch doesn't catch comments indented by spaces but I fixed comments > adjacent to warnings as well so they would remain aligned. > > Signed-off-by: Juston Li > --- > diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c > index 7826376..23d6e19 100644 > --- a/drivers/staging/sm750fb/ddk750_hwi2c.c > +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c > @@ -9,71 +9,69 @@ > #define HWI2C_WAIT_TIMEOUT 0xF0000 > > > -int hwI2CInit( > - unsigned char busSpeedMode > -) > +int hwI2CInit(unsigned char busSpeedMode) but this is what you say in commit message. Please only do one type of change in a single patch. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/