Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753821AbbFTIHg (ORCPT <rfc822;w@1wt.eu>);
	Sat, 20 Jun 2015 04:07:36 -0400
Received: from mail-oi0-f46.google.com ([209.85.218.46]:35461 "EHLO
	mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751811AbbFTIHZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 20 Jun 2015 04:07:25 -0400
MIME-Version: 1.0
In-Reply-To: <20150620074335.GB15195@sudip-PC>
References: <1434779457-18601-1-git-send-email-juston.h.li@gmail.com>
	<20150620074335.GB15195@sudip-PC>
Date: Sat, 20 Jun 2015 01:07:24 -0700
X-Google-Sender-Auth: bvIvZutPazj41-PXCRZGlOPNCc8
Message-ID: <CAFow2F_T4d-gkr8Ago8kvgagFwDUA_7ea67d8kcrb6O_0k+Y=w@mail.gmail.com>
Subject: Re: [PATCH v3] staging: sm750fb: use tabs for indentation
From: Juston Li <juston.h.li@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: teddy.wang@siliconmotion.com, Greg KH <gregkh@linuxfoundation.org>,
        linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1496
Lines: 40

On Sat, Jun 20, 2015 at 12:43 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Fri, Jun 19, 2015 at 10:50:57PM -0700, Juston Li wrote:
>> Replace spaces with tabs for indentation to fix the checkpatch.pl warning
>> 'WARNING: please, no spaces at the start of a line'
>>
>> checkpatch doesn't catch comments indented by spaces but I fixed comments
>> adjacent to warnings as well so they would remain aligned.
>>
>> Signed-off-by: Juston Li <juston.h.li@gmail.com>
>> ---
> <snip>
>> diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
>> index 7826376..23d6e19 100644
>> --- a/drivers/staging/sm750fb/ddk750_hwi2c.c
>> +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c
>> @@ -9,71 +9,69 @@
>>  #define HWI2C_WAIT_TIMEOUT              0xF0000
>>
>>
>> -int hwI2CInit(
>> -    unsigned char busSpeedMode
>> -)
>> +int hwI2CInit(unsigned char busSpeedMode)
> but this is what you say in commit message. Please only do one type of
> change in a single patch.

Yeah, there were a couple of those changes I forgot to mention.
They were cases where there was nothing to align the lines to and it was
easier just to fix the overall code style.

It is a separate change so I'll remove the changes and resend.
I actually finished on several other  checkpatch.pl fix patches so
I'll just include this in a patchset.

Regards
Juston
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/