Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753661AbbFTKpS (ORCPT ); Sat, 20 Jun 2015 06:45:18 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35418 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbbFTKpN (ORCPT ); Sat, 20 Jun 2015 06:45:13 -0400 Date: Sat, 20 Jun 2015 16:15:05 +0530 From: Sudip Mukherjee To: Juston Li Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging: sm750fb: use tabs for indentation Message-ID: <20150620104505.GB29626@sudip-PC> References: <1434790115-21683-1-git-send-email-juston.h.li@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434790115-21683-1-git-send-email-juston.h.li@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 29 On Sat, Jun 20, 2015 at 01:48:32AM -0700, Juston Li wrote: > Replace spaces with tabs for indentation to fix the checkpatch.pl error > ERROR: code indent should use tabs where possible > WARNING: please, no spaces at the start of a line > > Signed-off-by: Juston Li > --- > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > index b6395b8..c09748c 100644 > --- a/drivers/staging/sm750fb/ddk750_sii164.c > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > > @@ -279,27 +279,25 @@ char *sii164GetChipString(void) > * Input: > * powerUp - Flag to set the power down or up > */ > -void sii164SetPower( > - unsigned char powerUp > -) > +void sii164SetPower(unsigned char powerUp) is it that same patch again? different kind of change should go in a separate patch. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/