Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755064AbbFTMkt (ORCPT ); Sat, 20 Jun 2015 08:40:49 -0400 Received: from smtp81.iad3a.emailsrvr.com ([173.203.187.81]:38591 "EHLO smtp81.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754961AbbFTMko (ORCPT ); Sat, 20 Jun 2015 08:40:44 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <55855F49.8080407@mev.co.uk> Date: Sat, 20 Jun 2015 13:40:41 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "Abdul, Hussain (H.)" , "gregkh@linuxfoundation.org" CC: "hsweeten@visionengravers.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence References: In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1369 Lines: 35 On 19/06/15 06:59, Abdul, Hussain (H.) wrote: > > > This patch simplify a trivial if-return sequence. Possibly combine with > a preceding function call. > > Abdul Hussain (6): > staging: comedi: dmm32at: Simplify a trivial if-return sequence > staging: comedi: fl512: Simplify a trivial if-return sequence > staging: comedi: daqboard2000: Simplify a trivial if-return sequence > staging: comedi: dac02: Simplify a trivial if-return sequence > staging: comedi: daq_dio24: Simplify a trivial if-return sequence > staging: comedi: s626: Simplify a trivial if-return sequence > > > drivers/staging/comedi/drivers/dac02.c | 6 +----- > drivers/staging/comedi/drivers/daqboard2000.c | 7 +------ > drivers/staging/comedi/drivers/dmm32at.c | 6 +----- > drivers/staging/comedi/drivers/fl512.c | 6 +----- > drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +----- > drivers/staging/comedi/drivers/s626.c | 6 +----- Looks good apart from the checkpatch warning in patch 3 as pointed out by Sudip. For patches 1-2 and 4-6: Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/