Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754516AbbFTOLw (ORCPT ); Sat, 20 Jun 2015 10:11:52 -0400 Received: from www.linutronix.de ([62.245.132.108]:60839 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752232AbbFTOLp (ORCPT ); Sat, 20 Jun 2015 10:11:45 -0400 Date: Sat, 20 Jun 2015 16:11:44 +0200 (CEST) From: Thomas Gleixner To: Brian Norris cc: Florian Fainelli , Gregory Fong , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Kevin Cernekee , Jason Cooper Subject: Re: [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip In-Reply-To: <1434756403-379-1-git-send-email-computersforpeace@gmail.com> Message-ID: References: <20150619224123.GL4917@ld-irv-0074> <1434756403-379-1-git-send-email-computersforpeace@gmail.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2083 Lines: 49 On Fri, 19 Jun 2015, Brian Norris wrote: > This patch adds a second set of suspend/resume hooks to irq_chip, this > time to represent *chip* suspend/resume, rather than IRQ suspend/resume. > These callbacks will always be called for an irqchip and are based on > the per-chip irq_chip_generic struct, rather than the per-IRQ irq_data > struct. There is no per-chip irq_chip_generic struct. It's only there if the irq chip has been instantiated as a generic chip. > /** > * struct irq_chip - hardware interrupt chip descriptor > * > @@ -317,6 +319,12 @@ static inline irq_hw_number_t irqd_to_hwirq(struct irq_data *d) > * @irq_suspend: function called from core code on suspend once per chip > * @irq_resume: function called from core code on resume once per chip > * @irq_pm_shutdown: function called from core code on shutdown once per chip > + * @chip_suspend: function called from core code on suspend once per > + * chip; for handling chip details even when no interrupts > + * are in use > + * @chip_resume: function called from core code on resume once per chip; > + * for handling chip details even when no interrupts are > + * in use > * @irq_calc_mask: Optional function to set irq_data.mask for special cases > * @irq_print_chip: optional to print special chip info in show_interrupts > * @irq_request_resources: optional to request resources before calling > @@ -357,6 +365,8 @@ struct irq_chip { > void (*irq_suspend)(struct irq_data *data); > void (*irq_resume)(struct irq_data *data); > void (*irq_pm_shutdown)(struct irq_data *data); > + void (*chip_suspend)(struct irq_chip_generic *gc); > + void (*chip_resume)(struct irq_chip_generic *gc); I really don't want to set a precedent for random (*foo)(*bar) callbacks. > + > + if (ct->chip.chip_suspend) > + ct->chip.chip_suspend(gc); So wouldn't it be the more intuitive solution to make this a callback in the struct gc itself? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/