Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755059AbbFTPk2 (ORCPT ); Sat, 20 Jun 2015 11:40:28 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:34835 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754182AbbFTPkV (ORCPT ); Sat, 20 Jun 2015 11:40:21 -0400 MIME-Version: 1.0 In-Reply-To: <20150620104505.GB29626@sudip-PC> References: <1434790115-21683-1-git-send-email-juston.h.li@gmail.com> <20150620104505.GB29626@sudip-PC> Date: Sat, 20 Jun 2015 08:40:20 -0700 X-Google-Sender-Auth: Z0ag0bwFhdxu_n0yib6cxnPwUkA Message-ID: Subject: Re: [PATCH 1/4] staging: sm750fb: use tabs for indentation From: Juston Li To: Sudip Mukherjee Cc: teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 37 My apologies, I thought I removed all of those. Fixed for real this time, resending. Regards Juston On Sat, Jun 20, 2015 at 3:45 AM, Sudip Mukherjee wrote: > On Sat, Jun 20, 2015 at 01:48:32AM -0700, Juston Li wrote: >> Replace spaces with tabs for indentation to fix the checkpatch.pl error >> ERROR: code indent should use tabs where possible >> WARNING: please, no spaces at the start of a line >> >> Signed-off-by: Juston Li >> --- > >> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c >> index b6395b8..c09748c 100644 >> --- a/drivers/staging/sm750fb/ddk750_sii164.c >> +++ b/drivers/staging/sm750fb/ddk750_sii164.c > >> >> @@ -279,27 +279,25 @@ char *sii164GetChipString(void) >> * Input: >> * powerUp - Flag to set the power down or up >> */ >> -void sii164SetPower( >> - unsigned char powerUp >> -) >> +void sii164SetPower(unsigned char powerUp) > is it that same patch again? different kind of change should go in a separate patch. > > regards > sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/